Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbcKIIrf (ORCPT ); Wed, 9 Nov 2016 03:47:35 -0500 Received: from up.free-electrons.com ([163.172.77.33]:36932 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751542AbcKIIre (ORCPT ); Wed, 9 Nov 2016 03:47:34 -0500 From: Gregory CLEMENT To: Marcin Wojtas Cc: Thomas Petazzoni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, will.deacon@arm.com, robh+dt@kernel.org, mark.rutland@arm.com, nadavh@marvell.com, alior@marvell.com, jaz@semihalf.com, tn@semihalf.com Subject: Re: [PATCH] arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers References: <1478622692-18441-1-git-send-email-mw@semihalf.com> <20161108174851.2cd8efb4@free-electrons.com> Date: Wed, 09 Nov 2016 09:47:32 +0100 In-Reply-To: <20161108174851.2cd8efb4@free-electrons.com> (Thomas Petazzoni's message of "Tue, 8 Nov 2016 17:48:51 +0100") Message-ID: <8737j1m44b.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 59 Hi Marcin, On mar., nov. 08 2016, Thomas Petazzoni wrote: > Hello, > > On Tue, 8 Nov 2016 17:31:32 +0100, Marcin Wojtas wrote: >> Enabling SPI controllers, which are attached to different busses >> inside an SoC, may result in overlapping enumeration and cause >> sysfs registration failure. Example log after enabling two >> controllers on Armada 8040 SoC with same identifiers: >> >> [ 3.740415] sysfs: cannot create duplicate filename >> '/class/spi_master/spi0' >> [ 3.747510] ------------[ cut here ]------------ >> [ 3.752145] WARNING: at fs/sysfs/dir.c:31 >> [...] >> [ 4.002299] orion_spi: probe of f4700600.spi failed with error -17 >> >> spi-orion driver offers dedicated DT property ('cell-index'), that >> allow setting unique identifiers. Recently added support for CP110-slave >> HW block introduced two new SPI controllers' nodes with same ID as >> ones from CP110-master. >> >> This commit fixes the issue by assigning different 'cell-index' values >> for CP110-slave SPI controllers. >> >> Fixes: 4eef78a0091b ("arm64: dts: marvell: add description for the slave >> CP110 in Armada 8K") >> Signed-off-by: Marcin Wojtas > > It's sad that we need to hardcode those indexes in the Device Tree > (which by no means are a description of the HW by the way), but that's > what the SPI framework expects I believe. Therefore: > > Acked-by: Thomas Petazzoni Applied on mvebu/fixes with acked-by from Thomas. In the same time I also applied "arm64: dts: marvell: fix clocksource for CP110 slave SPI0" which didn't find his way to mainline yet. Thanks, Gregory > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com