Date: Tue, 6 May 2003 18:24:56 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>
Cc: devenyga@mcmaster.ca, rml@tech9.net, linux-kernel@vger.kernel.org,
       torvalds@transmeta.com
Subject: Re: PATCH: Replace current->state with set_current_state in 2.5.6 8
Message-Id: <20030506182456.644b70d1.rddunlap@osdl.org>
In-Reply-To: <A46BBDB345A7D5118EC90002A5072C780C8FDEAD@orsmsx116.jf.intel.com>
References: <A46BBDB345A7D5118EC90002A5072C780C8FDEAD@orsmsx116.jf.intel.com>
Organization: OSDL
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2167
Lines: 58


On Tue, 6 May 2003 17:33:26 -0700  "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com> wrote:

| > From: Gabriel Devenyi [mailto:devenyga@mcmaster.ca]
| > 
| > This patch appies to 2.5.68 and replaces any remaining current->state
| lines
| >  with set_current_state. This from the TODO list of Kernel Janitors.
| > 
| >
| http://muss.mcmaster.ca/~devenyga/patch-linux-2.5.68-set_current_state.patch
| 
| Some time ago I sent a patch doing this only on */fs/* [not the filesystem's
| code, just the common stuff]. It was dismissed by Linus under
| I-don't-know-what
| -the-hell-reasons (it's very smart to dismiss something without reason,
| gives
| the original poster a very clear idea of what needs to be changed -
| nevermind, just being ironic). 
| 
| However, I'd suggest to post this into the Kernel Janitors mailing list and
| let one of the big guys there swipe it in.
| 
| Maybe Robert Love can provide more highlight.


Yes, the KJ list has already seen this patch and commented on some version
of it.

Folks, IMO for KJ work to be successful (merged) and rewarding, and for it
to continue, we need:

- TODO list updated with accurate descriptions of problems and expected
  changes to fix them;
- a plan of attack for getting them merged;

We shouldn't just expect (for example) Gabriel's patch to be merged
on its own.

Even if Gabriel's patch is perfect, I don't expect that Linus will merge it,
esp. not now, but not even earlier in 2.5 days.  For one thing, it's
176 KB, so it needs to be broken down by subsystem/driver/filesystem/etc.

Then it needs some exposure, like living in -ac or -mm or -pick1,
or at least some testing (everyday usage) by a few people, with reports
from them.

And I don't really want to review a 176 KB patch (although I did already
look over most of it a few days ago).  Do people want to take portions
of it for review and then see about Alan merging it, e.g.?

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/