Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621AbcKIKlB (ORCPT ); Wed, 9 Nov 2016 05:41:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbcKIKlA (ORCPT ); Wed, 9 Nov 2016 05:41:00 -0500 Date: Wed, 9 Nov 2016 05:40:58 -0500 From: Jessica Yu To: Aaron Tomlin Cc: Steven Rostedt , linux-kernel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: module: When modifying a module's text ignore modules which are going away too Message-ID: <20161109104058.GB27196@packer-debian-8-amd64.digitalocean.com> References: <20161026080914.5bc68d0d@gandalf.local.home> <1477560966-781-1-git-send-email-atomlin@redhat.com> <20161027094934.296d668d@gandalf.local.home> <20161107114629.GB16093@atomlin.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20161107114629.GB16093@atomlin.usersys.redhat.com> X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 09 Nov 2016 10:40:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 20 +++ Aaron Tomlin [07/11/16 11:46 +0000]: >Hi Jessica, > >Any thoughts? Hi Aaron, Thanks for your patience as I slowly work through a large swath of emails :-) Anyway, this looks fine to me. A going module's text should be (or soon will be) rw anyway, so checking for going modules in the ro case should be enough. Rusty, if you give your ack for the second patch, I can apply both patches to my modules-next branch. I'll also incorporate Steven's suggestion for a comment explaining why going modules shouldn't be converted to ro in this context. Thanks, Jessica