Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933888AbcKILdo (ORCPT ); Wed, 9 Nov 2016 06:33:44 -0500 Received: from mail-ua0-f172.google.com ([209.85.217.172]:33124 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbcKILF7 (ORCPT ); Wed, 9 Nov 2016 06:05:59 -0500 MIME-Version: 1.0 In-Reply-To: <1478665889.2533.8.camel@ranerica-desktop> References: <1478585533-19406-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <20161108131600.GF3117@twins.programming.kicks-ass.net> <1478665889.2533.8.camel@ranerica-desktop> From: Andy Lutomirski Date: Wed, 9 Nov 2016 03:05:37 -0800 Message-ID: Subject: Re: [PATCH 0/4] x86: enable User-Mode Instruction Prevention To: Ricardo Neri Cc: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , X86 ML , "linux-doc@vger.kernel.org" , Andy Lutomirski , Andrew Morton , Borislav Petkov , Brian Gerst , Chen Yucong , Chris Metcalf , Dave Hansen , Fenghua Yu , Huang Rui , Jiri Slaby , Jonathan Corbet , "Michael S . Tsirkin" , Paul Gortmaker , "Ravi V . Shankar" , Vlastimil Babka , Shuah Khan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 33 On Tue, Nov 8, 2016 at 8:31 PM, Ricardo Neri wrote: > On Tue, 2016-11-08 at 07:34 -0800, Andy Lutomirski wrote: >> > Would it not be better to emulate these instructions for them? What >> way >> > we can verify they're not malicious. >> >> Forget malice -- if they are really needed for some silly vm86-using >> program, let's trap them and emulate them so they return dummy values. >> >> Also, keep in mind that vm86 is already effectively gated behind a >> sysctl for non-root. I think the default should be that, if root has >> enabled vm86, it should work. > > Then should I keep UMIP enabled by default and still provide an option > to disable it via a kernel parameter? Probably, but clearcpuid might be good enough. There might be some unexpected breakage. > > Also, a third option, umip=novm86 would "disable" UMIP in vm86 tasks. > Under the new approach (of emulating the impacted instructions), this > option, a #GP fault would still be generated but the actual values of > GDT/LDT/IDT/MSW would be passed to user space. Does this make sense? I don't think so. As far as I know, there is no legitimate reason for a vm86-using program to care about what these instructions spit out. Heck, in real mode and vm86 mode, there aren't segment descriptors at all, so the GDT is really quite useless even if it were readable. I would suggest having all of these instructions return compile-time constants in vm86 mode.