Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbcKILwF (ORCPT ); Wed, 9 Nov 2016 06:52:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46630 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbcKILwD (ORCPT ); Wed, 9 Nov 2016 06:52:03 -0500 Subject: Re: [PATCH v2] leds: ledtrig-heartbeat: Make top brightness adjustable To: Jacek Anaszewski , linux-leds@vger.kernel.org References: <1478688226-4158-1-git-send-email-j.anaszewski@samsung.com> Cc: linux-kernel@vger.kernel.org, Pavel Machek From: Hans de Goede Message-ID: Date: Wed, 9 Nov 2016 12:51:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478688226-4158-1-git-send-email-j.anaszewski@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 09 Nov 2016 11:51:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3116 Lines: 92 Hi, On 09-11-16 11:43, Jacek Anaszewski wrote: > LED class heartbeat trigger allowed only for blinking with max_brightness > value. This patch adds more flexibility by exploiting part of LED core > software blink infrastructure. > > Signed-off-by: Jacek Anaszewski > Cc: Pavel Machek > Cc: Hans de Goede > --- > Changes since v1: > - after introduction of work_flags and new_blink_brightness properties > this patch needs to be updated Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > drivers/leds/trigger/ledtrig-heartbeat.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/leds/trigger/ledtrig-heartbeat.c b/drivers/leds/trigger/ledtrig-heartbeat.c > index c9f3862..e6f2f8b 100644 > --- a/drivers/leds/trigger/ledtrig-heartbeat.c > +++ b/drivers/leds/trigger/ledtrig-heartbeat.c > @@ -43,6 +43,9 @@ static void led_heartbeat_function(unsigned long data) > return; > } > > + if (test_and_clear_bit(LED_BLINK_BRIGHTNESS_CHANGE, &led_cdev->work_flags)) > + led_cdev->blink_brightness = led_cdev->new_blink_brightness; > + > /* acts like an actual heart beat -- ie thump-thump-pause... */ > switch (heartbeat_data->phase) { > case 0: > @@ -59,26 +62,26 @@ static void led_heartbeat_function(unsigned long data) > delay = msecs_to_jiffies(70); > heartbeat_data->phase++; > if (!heartbeat_data->invert) > - brightness = led_cdev->max_brightness; > + brightness = led_cdev->blink_brightness; > break; > case 1: > delay = heartbeat_data->period / 4 - msecs_to_jiffies(70); > heartbeat_data->phase++; > if (heartbeat_data->invert) > - brightness = led_cdev->max_brightness; > + brightness = led_cdev->blink_brightness; > break; > case 2: > delay = msecs_to_jiffies(70); > heartbeat_data->phase++; > if (!heartbeat_data->invert) > - brightness = led_cdev->max_brightness; > + brightness = led_cdev->blink_brightness; > break; > default: > delay = heartbeat_data->period - heartbeat_data->period / 4 - > msecs_to_jiffies(70); > heartbeat_data->phase = 0; > if (heartbeat_data->invert) > - brightness = led_cdev->max_brightness; > + brightness = led_cdev->blink_brightness; > break; > } > > @@ -133,7 +136,10 @@ static void heartbeat_trig_activate(struct led_classdev *led_cdev) > setup_timer(&heartbeat_data->timer, > led_heartbeat_function, (unsigned long) led_cdev); > heartbeat_data->phase = 0; > + if (!led_cdev->blink_brightness) > + led_cdev->blink_brightness = led_cdev->max_brightness; > led_heartbeat_function(heartbeat_data->timer.data); > + set_bit(LED_BLINK_SW, &led_cdev->work_flags); > led_cdev->activated = true; > } > > @@ -145,6 +151,7 @@ static void heartbeat_trig_deactivate(struct led_classdev *led_cdev) > del_timer_sync(&heartbeat_data->timer); > device_remove_file(led_cdev->dev, &dev_attr_invert); > kfree(heartbeat_data); > + clear_bit(LED_BLINK_SW, &led_cdev->work_flags); > led_cdev->activated = false; > } > } >