Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932267AbcKIL6S (ORCPT ); Wed, 9 Nov 2016 06:58:18 -0500 Received: from mga01.intel.com ([192.55.52.88]:57043 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbcKIL6P (ORCPT ); Wed, 9 Nov 2016 06:58:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,614,1473145200"; d="scan'208";a="784333027" From: Jani Nikula To: Markus Heiser Cc: Josh Triplett , Mauro Carvalho Chehab , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, ksummit-discuss@lists.linuxfoundation.org, linux-doc@vger.kernel.org Subject: Re: [Ksummit-discuss] Including images on Sphinx documents In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20161107075524.49d83697@vento.lan> <20161107170133.4jdeuqydthbbchaq@x> <8737j0hpi0.fsf@intel.com> Date: Wed, 09 Nov 2016 13:58:12 +0200 Message-ID: <87shr0g90r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1697 Lines: 50 On Wed, 09 Nov 2016, Markus Heiser wrote: > Am 09.11.2016 um 12:16 schrieb Jani Nikula : >>> So I vote for : >>> >>>> 1) copy (or symlink) all rst files to Documentation/output (or to the >>>> build dir specified via O= directive) and generate the *.pdf there, >>>> and produce those converted images via Makefile.; >> >> We're supposed to solve problems, not create new ones. > > ... new ones? ... Handle in-tree builds without copying. Make dependency analysis with source rst and "intermediate" rst work. Make sure your copying gets the timestamps right. Make Sphinx dependency analysis look at the right copies depending on in-tree vs. out-of-tree. Generally make sure it doesn't confuse Sphinx's own dependency analysis. The stuff I didn't think of. Sure, it's all supposed to be basic Makefile stuff, but don't make the mistake of thinking just one invocation of 'cp' will solve all the problems. It all adds to the complexity we were trying to avoid when dumping DocBook. It adds to the complexity of debugging stuff. (And hey, there's still the one rebuilding-stuff-for-no-reason issue open.) If you want to keep the documentation build sane, try to avoid the Makefile preprocessing. And same old story, if you fix this for real, even if as a Sphinx extension, *other* people than kernel developers will be interested, and *we* don't have to do so much ourselves. BR, Jani. > >>> IMO placing 'sourcedir' to O= is more sane since this marries the >>> Linux Makefile concept (relative to $PWD) with the sphinx concept >>> (in or below 'sourcedir'). > > -- Markus -- -- Jani Nikula, Intel Open Source Technology Center