MIME-Version: 1.0
In-Reply-To: <20161109114217.GO25290@imgtec.com>
References: <20161108101558.ihvrprbbdqjwu5wg@phenom.ffwll.local>
 <20161109001805.10628-1-eric@engestrom.ch> <20161109010916.rpsqcswnlyxggovd@phenom.ffwll.local>
 <20161109011325.hvvfsvpq734nduxd@phenom.ffwll.local> <20161109114217.GO25290@imgtec.com>
From: Daniel Vetter <daniel@ffwll.ch>
Date: Wed, 9 Nov 2016 14:13:40 +0100
Message-ID: <CAKMK7uHC9Z1DK_ni=9e0ukWnt70f_T1VCg9N7gp51Nqpqrvcig@mail.gmail.com>
Subject: Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Eric Engestrom <eric@engestrom.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@linux.ie>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        Daniel Vetter <daniel.vetter@intel.com>, Flora Cui <Flora.Cui@amd.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Tom St Denis <tom.stdenis@amd.com>,
        Chunming Zhou <David1.Zhou@amd.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Sinclair Yeh <syeh@vmware.com>,
        Xinliang Liu <z.liuxinliang@hisilicon.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Vitaly Prosyak <vitaly.prosyak@amd.com>,
        Alexandre Demers <alexandre.f.demers@gmail.com>,
        Jani Nikula <jani.nikula@intel.com>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        Emily Deng <Emily.Deng@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        Junwei Zhang <Jerry.Zhang@amd.com>,
        =?UTF-8?Q?Michel_D=C3=A4nzer?= <michel.daenzer@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1340
Lines: 32

On Wed, Nov 9, 2016 at 12:42 PM, Eric Engestrom
<eric.engestrom@imgtec.com> wrote:
>> Well, had to drop it again since it didn't compile:
>>
>>
>>   CC [M]  drivers/gpu/drm/drm_blend.o
>> drivers/gpu/drm/drm_atomic.c: In function ‘drm_atomic_plane_print_state’:
>> drivers/gpu/drm/drm_atomic.c:920:5: error: too few arguments to function ‘drm_get_format_name’
>>      drm_get_format_name(fb->pixel_format));
>>      ^~~~~~~~~~~~~~~~~~~
>> In file included from ./include/drm/drmP.h:71:0,
>>                  from drivers/gpu/drm/drm_atomic.c:29:
>> ./include/drm/drm_fourcc.h:65:7: note: declared here
>>  char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf);
>>        ^~~~~~~~~~~~~~~~~~~
>>
>> Can you pls rebase onto drm-misc or linux-next or something?
>
> That was based on airlied/drm-next (last fetched on Sunday I think),
> I can rebase it on drm-misc if it helps, but it seems older than
> drm-next.
> Should I just rebase on top of current head of drm-next?

It needs to be drm-misc (linux-next doesn't have it yet) due to the
new atomic debug work that we just landed. I'm working on drm-tip as a
drm local integration tree to ease pains like these a bit, but that
doesn't really exist yet.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch