Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932846AbcKINq7 (ORCPT ); Wed, 9 Nov 2016 08:46:59 -0500 Received: from mga01.intel.com ([192.55.52.88]:44180 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbcKINqv (ORCPT ); Wed, 9 Nov 2016 08:46:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,614,1473145200"; d="scan'208";a="29180536" From: Grzegorz Andrejczuk To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org Cc: bp@suse.de, dave.hansen@linux.intel.com, lukasz.daniluk@intel.com, james.h.cownie@intel.com, jacob.jun.pan@intel.com, Piotr.Luc@intel.com, linux-kernel@vger.kernel.org, Grzegorz Andrejczuk Subject: [PATCH v9 4/4] x86/cpufeatures: handle RING3MWAIT on Xeon Phi models Date: Wed, 9 Nov 2016 14:46:34 +0100 Message-Id: <1478699194-30946-5-git-send-email-grzegorz.andrejczuk@intel.com> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1478699194-30946-1-git-send-email-grzegorz.andrejczuk@intel.com> References: <1478699194-30946-1-git-send-email-grzegorz.andrejczuk@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3414 Lines: 113 Unfortunately presence of this feature cannot be detected automatically (by reading some other MSR) therefore it is required to do explicit check for the family and model of the cpu. If processor is Intel Xeon Phi x200 RING 3 MONITOR/MWAIT feature is enabled by setting cpu cap X86_FEATURE_RING3MWAIT and elf HWCAP2_RING3MWAIT. Signed-off-by: Grzegorz Andrejczuk --- Documentation/kernel-parameters.txt | 6 +++++ Documentation/x86/x86_64/boot-options.txt | 5 ++++ arch/x86/kernel/cpu/intel.c | 39 +++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index a4f4d69..4683cc1 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -3120,6 +3120,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. pg. [PARIDE] See Documentation/blockdev/paride.txt. + phir3mwait= [X86-64] Disable ring 3 MONITOR/MWAIT on Intel Xeon Phi + codenamed Knight Landing cpus. + It has no effect on cpus other than Intel Xeon Phi. + Format: { disable } + See Documentation/x86/x86_64/boot-options.txt + pirq= [SMP,APIC] Manual mp-table setup See Documentation/x86/i386/IO-APIC.txt. diff --git a/Documentation/x86/x86_64/boot-options.txt b/Documentation/x86/x86_64/boot-options.txt index 0965a71..1a515e8 100644 --- a/Documentation/x86/x86_64/boot-options.txt +++ b/Documentation/x86/x86_64/boot-options.txt @@ -281,6 +281,11 @@ Debugging kstack=N Print N words from the kernel stack in oops dumps. + phir3mwait=disable + Disables unconditional setting bit 1 of the MSR_MISC_FEATURE_ENABLES + for Intel Xeon Phi, this way administrator can switch off ring 3 mwait + feature. + Miscellaneous nogbpages diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index fcd484d..3bfc8e5 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -14,6 +14,8 @@ #include #include #include +#include +#include #ifdef CONFIG_X86_64 #include @@ -61,6 +63,41 @@ void check_mpx_erratum(struct cpuinfo_x86 *c) } } +#ifdef CONFIG_X86_64 +static int phi_r3mwait_disabled __read_mostly; + +static int __init phir3mwait_disable(char *__unused) +{ + phi_r3mwait_disabled = 1; + return 1; +} +__setup("phir3mwait=disable", phir3mwait_disable); + +static void probe_xeon_phi_r3mwait(struct cpuinfo_x86 *c) +{ + /* + * Ring 3 MONITOR/MWAIT feature cannot be detected without + * cpu model and family comparison. + */ + if (c->x86 != 6 || c->x86_model != INTEL_FAM6_XEON_PHI_KNL) + return; + + if (phi_r3mwait_disabled) { + msr_clear_bit(MSR_MISC_FEATURE_ENABLES, + MSR_MISC_FEATURE_ENABLES_RING3MWAIT_BIT); + return; + } + + msr_set_bit(MSR_MISC_FEATURE_ENABLES, + MSR_MISC_FEATURE_ENABLES_RING3MWAIT_BIT); + set_cpu_cap(c, X86_FEATURE_RING3MWAIT); + ELF_HWCAP2 |= HWCAP2_RING3MWAIT; +} + +#else +static void probe_xeon_phi_r3mwait(struct cpuinfo_x86 *__unused) {} +#endif + static void early_init_intel(struct cpuinfo_x86 *c) { u64 misc_enable; @@ -565,6 +602,8 @@ static void init_intel(struct cpuinfo_x86 *c) detect_vmx_virtcap(c); init_intel_energy_perf(c); + + probe_xeon_phi_r3mwait(c); } #ifdef CONFIG_X86_32 -- 2.5.1