Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbcKIRD0 (ORCPT ); Wed, 9 Nov 2016 12:03:26 -0500 Received: from foss.arm.com ([217.140.101.70]:59280 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcKIRDY (ORCPT ); Wed, 9 Nov 2016 12:03:24 -0500 Date: Wed, 9 Nov 2016 17:03:26 +0000 From: Will Deacon To: Don Dutile Cc: Alex Williamson , Christoffer Dall , Eric Auger , eric.auger.pro@gmail.com, marc.zyngier@arm.com, robin.murphy@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, benh@kernel.crashing.org, arnd@arndb.de, jcm@redhat.com, dwmw@amazon.co.uk Subject: Re: Summary of LPC guest MSI discussion in Santa Fe Message-ID: <20161109170326.GG17771@arm.com> References: <1478209178-3009-1-git-send-email-eric.auger@redhat.com> <20161103220205.37715b49@t450s.home> <20161108024559.GA20591@arm.com> <20161108202922.GC15676@cbox> <20161108163508.1bcae0c2@t450s.home> <58228F71.6020108@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58228F71.6020108@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 29 On Tue, Nov 08, 2016 at 09:52:33PM -0500, Don Dutile wrote: > On 11/08/2016 06:35 PM, Alex Williamson wrote: > >On Tue, 8 Nov 2016 21:29:22 +0100 > >Christoffer Dall wrote: > >>Is my understanding correct, that you need to tell userspace about the > >>location of the doorbell (in the IOVA space) in case (2), because even > >>though the configuration of the device is handled by the (host) kernel > >>through trapping of the BARs, we have to avoid the VFIO user programming > >>the device to create other DMA transactions to this particular address, > >>since that will obviously conflict and either not produce the desired > >>DMA transactions or result in unintended weird interrupts? Yes, that's the crux of the issue. > >Correct, if the MSI doorbell IOVA range overlaps RAM in the VM, then > >it's potentially a DMA target and we'll get bogus data on DMA read from > >the device, and lose data and potentially trigger spurious interrupts on > >DMA write from the device. Thanks, > > > That's b/c the MSI doorbells are not positioned *above* the SMMU, i.e., > they address match before the SMMU checks are done. if > all DMA addrs had to go through SMMU first, then the DMA access could > be ignored/rejected. That's actually not true :( The SMMU can't generally distinguish between MSI writes and DMA writes, so it would just see a write transaction to the doorbell address, regardless of how it was generated by the endpoint. Will