Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbcKIRQb (ORCPT ); Wed, 9 Nov 2016 12:16:31 -0500 Received: from mail-db5eur01on0064.outbound.protection.outlook.com ([104.47.2.64]:60059 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754156AbcKIRQ2 (ORCPT ); Wed, 9 Nov 2016 12:16:28 -0500 From: Madalin-Cristian Bucur To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "oss@buserror.net" , "ppc@mindchasers.com" , "joe@perches.com" , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" Subject: RE: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Topic: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Index: AQHSNUiNwT1IEjDDuEKEIZQjO6RoxqDHrqoAgAlAjIA= Date: Wed, 9 Nov 2016 17:16:12 +0000 Message-ID: References: <1478117854-8952-1-git-send-email-madalin.bucur@nxp.com> <1478117854-8952-3-git-send-email-madalin.bucur@nxp.com> <20161103.155816.642712588084106823.davem@davemloft.net> In-Reply-To: <20161103.155816.642712588084106823.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; x-originating-ip: [192.88.146.1] x-ms-office365-filtering-correlation-id: 0e2a754e-4b82-4422-bc85-08d408c41b07 x-microsoft-exchange-diagnostics: 1;AM4PR04MB1602;7:sVuzE/1PlMtRi1AY2BjOJxlrPtlCqaDH8buJRXM0pYx+NnQIwnhckEjFJZTFw47fIQ2C3oM+2ao5AEyUS5ah8jWzWb9UVuTftPjdfko0iOid9ZE5/Nf76ozCsglX4E1TNRehFoFcU9XFUaQOD72UnbfWVNfDjlygNIyClQuqFrfMhQj+YrwLwelqeL2nSyaBJa3ftuT3aJG4etD7rFaosGnHQ0n5yZzuXdbPYZ7iu20sOIj5qTfHxHXmmQioFEqWmdFOzG+N3xPOYlLiHRxCovLF4jqJ4oqP2G9U07XsTrp3SjI05HxIpYE9CiR0OTlO2jSK0OmIX9jFoMTmq28uLpbA+9qkLcRnoPymhidZ4oY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1602; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6045074)(6040176)(6060229)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6061226)(6046074);SRVR:AM4PR04MB1602;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1602; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(199003)(189002)(586003)(77096005)(106116001)(2906002)(33656002)(50986999)(9686002)(105586002)(8936002)(189998001)(110136003)(2950100002)(86362001)(87936001)(3846002)(2900100001)(6916009)(6116002)(102836003)(5660300001)(97736004)(76176999)(54356999)(4326007)(92566002)(81156014)(7696004)(122556002)(76576001)(3280700002)(101416001)(3660700001)(8676002)(106356001)(7736002)(66066001)(7846002)(81166006)(68736007)(74316002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR04MB1602;H:AM4PR04MB1604.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2016 17:16:12.5125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1602 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA9HGZdi017339 Content-Length: 880 Lines: 29 > From: Madalin-Cristian Bucur > Sent: Monday, November 07, 2016 5:43 PM > > > From: David Miller [mailto:davem@davemloft.net] > > Sent: Thursday, November 03, 2016 9:58 PM > > > > From: Madalin Bucur > > Date: Wed, 2 Nov 2016 22:17:26 +0200 > > > > > This introduces the Freescale Data Path Acceleration Architecture > > > + int numstats = sizeof(struct rtnl_link_stats64) / sizeof(u64); > > ... > > > + cpustats = (u64 *)&percpu_priv->stats; > > > + > > > + for (j = 0; j < numstats; j++) > > > + netstats[j] += cpustats[j]; > > > > This is a memcpy() on well-typed datastructures which requires no > > casting or special handling whatsoever, so use memcpy instead of > > needlessly open coding the operation. > > Will fix. Took a second look at this, it's not copying but adding the percpu statistics into consolidated results. Madalin