Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbcKISYv (ORCPT ); Wed, 9 Nov 2016 13:24:51 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:36259 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754254AbcKISYn (ORCPT ); Wed, 9 Nov 2016 13:24:43 -0500 Date: Wed, 9 Nov 2016 12:24:41 -0600 From: Rob Herring To: Steve Twiss Cc: DEVICETREE , Dmitry Torokhov , LINUX-INPUT , LINUX-KERNEL , Mark Rutland , Eduardo Valentin , Guenter Roeck , LINUX-PM , LINUX-WATCHDOG , Lee Jones , Liam Girdwood , Mark Brown , Support Opensource , Wim Van Sebroeck , Zhang Rui Subject: Re: [PATCH V3 1/9] Documentation: devicetree: input: additions for da9061 onkey driver Message-ID: <20161109182441.jlk5clp5sviocv2q@rob-hp-laptop> References: <48abf6ce51f8ef02421ea2dd4f4e309b440efc85.1477929725.git.stwiss.opensource@diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48abf6ce51f8ef02421ea2dd4f4e309b440efc85.1477929725.git.stwiss.opensource@diasemi.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2779 Lines: 66 On Mon, Oct 31, 2016 at 04:02:02PM +0000, Steve Twiss wrote: > From: Steve Twiss > > Add binding information for DA9061 onkey. > > This patch updates the compatible string "dlg,da9061-onkey" to support > DA9061, removes the reference to KEY_SLEEP (which the driver no longer > supports) and fixes a typo in the example for DA9063. > > Supporting KEY_SLEEP was not the general convention and the typical > solution should have been for KEY_POWER to support both cases of suspend > and S/W power off. This change was sent to the DA9063 ONKEY device > driver in a separate patch, but the documentation was not updated at > that time. > - f889bea Report KEY_POWER instead of KEY_SLEEP during power key-press > > This patch also adds two new examples, one for DA9062 and one for DA9061. > The DA9061 examples uses a fall-back compatible string for the DA9062 > onkey driver. > > Signed-off-by: Steve Twiss > > --- > This patch applies against linux-next and v4.8 > > v2 -> v3 > - Patch renamed from [PATCH V2 01/10] to [PATCH V3 1/9] > - Each compatible line should be a valid combination of compatible > strings, alter DA9061 line to include the fall back compatible string > - Update the commit message to include KEY_SLEEP removal explanation and > a link back to the original device driver commit. This will allow full > traceability back to the original patch change > - Link in information about associated patches from this set without > describing them as being explicitly dependent on this binding > > v1 -> v2 > - Patch renamed from [PATCH V1 06/10] to [PATCH V2 01/10] -- these > changes were made to fix checkpatch warnings caused by the patch > set dependency order > - Typo s/ther/the/ in commit message > - Explanation about why KEY_SLEEP was removed (see below) > - Addition of DA9062 example > - Addition of a DA9061 example to follow the driver fall-back compatible > convention being applied for this device driver > > Hi, > > There is also new binding examples for DA9062 and DA9061. Importantly, > the Linux device driver changes for DA9061 were rejected because the > DA9062 device driver can be reused. For this reason, the DA9061 example > uses a fall-back compatible string. > > Other information: > The device driver from this patch set (associated with this binding) was > applied by Dmitry Torokhov on 26-Oct-2016. See: > - [PATCH V2 07/10] Input: da9061: onkey driver. > - https://lkml.org/lkml/2016/10/26/1169 > > Regards, > Steve Twiss, Dialog Semiconductor Ltd. > > > .../devicetree/bindings/input/da9062-onkey.txt | 45 ++++++++++++++-------- > 1 file changed, 30 insertions(+), 15 deletions(-) Acked-by: Rob Herring