Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932881AbcKIS0D (ORCPT ); Wed, 9 Nov 2016 13:26:03 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38462 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbcKIS0B (ORCPT ); Wed, 9 Nov 2016 13:26:01 -0500 Date: Wed, 09 Nov 2016 13:25:59 -0500 (EST) Message-Id: <20161109.132559.2248490227331285339.davem@davemloft.net> To: tremyfr@gmail.com Cc: dave@thedillows.org, sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings From: David Miller In-Reply-To: <1478440952-24973-1-git-send-email-tremyfr@gmail.com> References: <1478440952-24973-1-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Nov 2016 09:26:30 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 19 From: Philippe Reynes Date: Sun, 6 Nov 2016 15:02:32 +0100 > When moving from typhoon_get_settings to typhoon_getlink_ksettings > in the commit f7a5537cd2a5 ("net: 3com: typhoon: use new api > ethtool_{get|set}_link_ksettings"), we use a local variable supported > but we forgot to update the struct ethtool_link_ksettings with > this value. > > We also initialize advertising to zero, because otherwise it may > be uninitialized if no case of the switch (tp->xcvr_select) is used. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - remove a duplicate "commit" in the commit log Applied.