Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833AbcKIS01 (ORCPT ); Wed, 9 Nov 2016 13:26:27 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:35654 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740AbcKIS0X (ORCPT ); Wed, 9 Nov 2016 13:26:23 -0500 Date: Wed, 9 Nov 2016 12:26:21 -0600 From: Rob Herring To: Jacek Anaszewski Cc: Andi Shyti , Mauro Carvalho Chehab , Sean Young , Mark Rutland , Richard Purdie , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver Message-ID: <20161109182621.ttfxtdt32q3cqce7@rob-hp-laptop> References: <20161102104010.26959-1-andi.shyti@samsung.com> <20161102104010.26959-6-andi.shyti@samsung.com> <70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com> <20161103101048.ofyoko4mkcypf44u@gangnam.samsung> <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 39 On Thu, Nov 03, 2016 at 11:39:21AM +0100, Jacek Anaszewski wrote: > On 11/03/2016 11:10 AM, Andi Shyti wrote: > > Hi Jacek, > > > > > Only DT bindings of LED class drivers should be placed in > > > Documentation/devicetree/bindings/leds. Please move it to the > > > media bindings. > > > > that's where I placed it first, but Rob asked me to put it in the > > LED directory and Cc the LED mailining list. > > > > That's the discussion of the version 2: > > > > https://lkml.org/lkml/2016/9/12/380 > > > > Rob, Jacek, could you please agree where I can put the binding? > > I'm not sure if this is a good approach. I've noticed also that > backlight bindings have been moved to leds, whereas they don't look > similarly. > > We have common.txt LED bindings, that all LED class drivers' bindings > have to follow. Neither backlight bindings nor these ones do that, > which introduces some mess. And there are probably LED bindings that don't follow common.txt either. > Eventually adding a sub-directory, e.g. remote_control could make it > somehow logically justified, but still - shouldn't bindings be > placed in the documentation directory related to the subsystem of the > driver they are predestined to? No. While binding directories often mirror the driver directories, they are not the same. Bindings are grouped by types of h/w and IR LEDs are a type of LED. If you prefer a sub-dir, that is fine with me. Rob