Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753957AbcKISnq (ORCPT ); Wed, 9 Nov 2016 13:43:46 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33472 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbcKISnn (ORCPT ); Wed, 9 Nov 2016 13:43:43 -0500 Subject: Re: [PATCH v2 2/2] mmc: sdhci-iproc: support standard byte register accesses To: Adrian Hunter , Ulf Hansson , Rob Herring , Mark Rutland , Ray Jui , Scott Branden References: <1478018277-10097-1-git-send-email-scott.branden@broadcom.com> <1478018277-10097-3-git-send-email-scott.branden@broadcom.com> <132c772b-d4b9-c4b6-2eca-0393e7c995f9@broadcom.com> Cc: BCM Kernel Feedback , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srinath Mannam From: Scott Branden Message-ID: Date: Wed, 9 Nov 2016 10:43:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <132c772b-d4b9-c4b6-2eca-0393e7c995f9@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 35 Hi Adrian/Ulf, Please ignore my comments in last email I sent out. The v2 patch documentation matches the code and is good. I am confusing myself between internal versions and external upstream versions of this code. On 16-11-09 10:38 AM, Scott Branden wrote: > Hi Adrian/Ulf, > > On 16-11-08 01:55 AM, Adrian Hunter wrote: >> On 01/11/16 18:37, Scott Branden wrote: >>> Add bytewise register accesses support for newer versions of IPROC >>> SDHCI controllers. >>> Previous sdhci-iproc versions of SDIO controllers >>> (such as Raspberry Pi and Cygnus) only allowed for 32-bit register >>> accesses. >>> >>> Signed-off-by: Srinath Mannam >>> Signed-off-by: Scott Branden >> >> This is unchanged from V1 which I acked, so: > I updated the binding name in the documentation but forgot to change it > in this patch. Now that Rob has ack'd the binding documentation I will > send out an updated patch with binding string in the code matching the > ack'd documentation. Ignore this - PATCH v2 is good. > >> >> Acked-by: Adrian Hunter >> > With the minor change I will add your ack to the next version I send out. > > Thanks, > Scott