Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbcKIUKi (ORCPT ); Wed, 9 Nov 2016 15:10:38 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34983 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcKIUKf (ORCPT ); Wed, 9 Nov 2016 15:10:35 -0500 Date: Wed, 9 Nov 2016 22:10:29 +0200 From: Krzysztof Kozlowski To: Jaehoon Chung Cc: Krzysztof Kozlowski , Heiko Stuebner , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, ulf.hansson@linaro.org, robh+dt@kernel.org, shawn.lin@rock-chips.com Subject: Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead of "clock-freq-min-max" Message-ID: <20161109201029.GE23534@kozik-lap> References: <20161103062135.10697-1-jh80.chung@samsung.com> <20161103184112.GB11071@kozik-lap> <4066252.a1W9ejEKHX@phil> <20161104150447.GA4829@kozik-lap> <72612112-3b79-8fd3-8be4-a8f60ab3b68a@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <72612112-3b79-8fd3-8be4-a8f60ab3b68a@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2240 Lines: 50 On Mon, Nov 07, 2016 at 09:38:15AM +0900, Jaehoon Chung wrote: > On 11/05/2016 12:04 AM, Krzysztof Kozlowski wrote: > > On Fri, Nov 04, 2016 at 12:19:49PM +0100, Heiko Stuebner wrote: > >> Hi Jaehoon, > >> > >> Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung: > >>> On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote: > >>>> On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote: > >>>>> In drivers/mmc/core/host.c, there is "max-frequency" property. > >>>>> It should be same behavior. So Use the "max-frequency" instead of > >>>>> "clock-freq-min-max". > >>>>> > >>>>> Signed-off-by: Jaehoon Chung > >>>>> --- > >>>>> > >>>>> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-monk.dts | 2 +- > >>>>> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > >>>>> 4 files changed, 4 insertions(+), 4 deletions(-) > >>>> > >>>> This looks totally independent to rest of patches so it can be applied > >>>> separately without any functional impact (except lack of minimum > >>>> frequency). Is that correct? > >>> > >>> You're right. I will split the patches. And will resend. > >>> Thanks! > >> > >> I think what Krzysztof was asking was just if he can simply pick up this patch > >> alone, as it does not require any of the previous changes. > >> > >> Same is true for the Rockchip patches I guess, so we could just take them > >> individually into samsung/rockchip dts branches. > > > > Yes, I wanted to get exactly this information. I couldn't find it in > > cover letter. > > In drivers/mmc/core/host.c, there already is "max-frequency" property. > It's same functionality with "clock-freq-min-max". > Minimum clock value can be fixed to 100K. because MMC core will check clock value from 400K to 100K. > But max-frequency can be difference. > If we can use "max-frequency" property, we don't need to use "clock-freq-min-max" property anymore. > I will resend the deprecated property instead of removing "clock-freq-min-max". > > If you want to pick this, it's possible to pick. Then i will resend the patches without dt patches. Thanks, applied. Best regards, Krzysztof