Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754113AbcKIUPZ (ORCPT ); Wed, 9 Nov 2016 15:15:25 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48346 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbcKIUPY (ORCPT ); Wed, 9 Nov 2016 15:15:24 -0500 Date: Wed, 9 Nov 2016 14:15:14 -0600 From: Reza Arbab To: Rob Herring Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , Frank Rowand , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linuxppc-dev , "linux-mm@kvack.org" , "devicetree@vger.kernel.org" , Bharata B Rao , Nathan Fontenot , Stewart Smith , Alistair Popple , Balbir Singh , "Aneesh Kumar K.V" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory References: <1478562276-25539-1-git-send-email-arbab@linux.vnet.ibm.com> <1478562276-25539-5-git-send-email-arbab@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Organization: IBM Linux Technology Center User-Agent: NeoMutt/20161104 (1.7.1) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110920-0024-0000-0000-000014FD5B8B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006049; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000189; SDB=6.00778750; UDB=6.00375113; IPR=6.00556108; BA=6.00004866; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013277; XFM=3.00000011; UTC=2016-11-09 20:15:20 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110920-0025-0000-0000-000046037568 Message-Id: <20161109201513.6q5fgfwkmyb2k63n@arbab-vm> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-09_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611090372 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 415 Lines: 11 On Wed, Nov 09, 2016 at 12:12:55PM -0600, Rob Herring wrote: >On Mon, Nov 7, 2016 at 5:44 PM, Reza Arbab wrote: >> + hotpluggable = of_get_flat_dt_prop(node, "linux,hotpluggable", NULL); > >Memory being hotpluggable doesn't seem like a linux property to me. >I'd drop the linux prefix. Also, this needs to be documented. Sure, that makes sense. I'll do both in v7. -- Reza Arbab