Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbcKIUQw (ORCPT ); Wed, 9 Nov 2016 15:16:52 -0500 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:50132 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcKIUQv (ORCPT ); Wed, 9 Nov 2016 15:16:51 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 09 Nov 2016 21:16:49 +0100 X-ME-IP: 109.222.248.68 From: Robert Jarzmik To: Arnd Bergmann Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250_pxa: hide early console setup when disabled References: <20161109132725.2072258-1-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 09 Nov 2016 21:16:45 +0100 In-Reply-To: <20161109132725.2072258-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 9 Nov 2016 14:27:00 +0100") Message-ID: <87wpgcv26q.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 499 Lines: 17 Arnd Bergmann writes: > The newly added pxa glue driver for 8250 supports console output, but > fails to build if the 8250 console is disabled: > > drivers/tty/serial/8250/8250_pxa.o: In function `early_serial_pxa_setup': > 8250_pxa.c:(.init.text+0x50): undefined reference to `early_serial8250_setup' > > This adds an #ifdef like the other glue drivers have it. > > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert