Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754196AbcKIUSH (ORCPT ); Wed, 9 Nov 2016 15:18:07 -0500 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:26150 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbcKIUSG (ORCPT ); Wed, 9 Nov 2016 15:18:06 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 09 Nov 2016 21:18:04 +0100 X-ME-IP: 109.222.248.68 From: Robert Jarzmik To: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable References: <20161108224756.25842-1-sboyd@codeaurora.org> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 09 Nov 2016 21:18:03 +0100 In-Reply-To: <20161108224756.25842-1-sboyd@codeaurora.org> (Stephen Boyd's message of "Tue, 8 Nov 2016 14:47:56 -0800") Message-ID: <87shr0v24k.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 513 Lines: 18 Stephen Boyd writes: > This function is passed an __iomem pointer but we use a u32 > pointer instead which makes checkers like spare complain. > Furthermore, "lock" is a pretty poor variable name for a string > that will go into lockdep reports and the symbol isn't marked > static. Cleanup all this. > > Cc: Robert Jarzmik > Signed-off-by: Stephen Boyd Most certainly. Acked-by: Robert Jarzmik Cheers. -- Robert