Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbcKIUnf (ORCPT ); Wed, 9 Nov 2016 15:43:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51704 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbcKIUnd (ORCPT ); Wed, 9 Nov 2016 15:43:33 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 82DD8605A0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 9 Nov 2016 12:43:31 -0800 From: Stephen Boyd To: Michael Turquette Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Robert Jarzmik Subject: Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable Message-ID: <20161109204331.GU16026@codeaurora.org> References: <20161108224756.25842-1-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161108224756.25842-1-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 552 Lines: 16 On 11/08, Stephen Boyd wrote: > This function is passed an __iomem pointer but we use a u32 > pointer instead which makes checkers like spare complain. > Furthermore, "lock" is a pretty poor variable name for a string > that will go into lockdep reports and the symbol isn't marked > static. Cleanup all this. > > Cc: Robert Jarzmik > Signed-off-by: Stephen Boyd > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project