Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbcKIVku (ORCPT ); Wed, 9 Nov 2016 16:40:50 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:35311 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbcKIVks (ORCPT ); Wed, 9 Nov 2016 16:40:48 -0500 MIME-Version: 1.0 In-Reply-To: <1474410485-1305-1-git-send-email-linux@rasmusvillemoes.dk> References: <1474410485-1305-1-git-send-email-linux@rasmusvillemoes.dk> From: Andrei Vagin Date: Wed, 9 Nov 2016 13:40:47 -0800 Message-ID: Subject: Re: [PATCH] fs/proc/array.c: slightly improve render_sigset_t To: Rasmus Villemoes Cc: Andrew Morton , Kees Cook , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 50 On Tue, Sep 20, 2016 at 3:28 PM, Rasmus Villemoes wrote: > format_decode and vsnprintf occasionally show up in perf top, so I > went looking for places that might not need the full printf > power. With the help of kprobes, I gathered some statistics on which > format strings we mostly pass to vsnprintf. On a trivial desktop > workload, I hit "%x" 25% of the time, so something apparently reads > /proc/pid/status (which does 5*16 printf("%x") calls) a lot. > > With this patch, reading /proc/pid/status is 30% faster according to > this microbenchmark: > > char buf[4096]; > int i, fd; > for (i = 0; i < 10000; ++i) { > fd = open("/proc/self/status", O_RDONLY); > read(fd, buf, sizeof(buf)); > close(fd); > } > Acked-by: Andrei Vagin Andrew, could you replace my patch "proc-optimize-render_sigset_t.patch" to this one. Thanks, Andrei > Signed-off-by: Rasmus Villemoes > --- > fs/proc/array.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/array.c b/fs/proc/array.c > index 88c7de12197b..7f73b689a15c 100644 > --- a/fs/proc/array.c > +++ b/fs/proc/array.c > @@ -251,7 +251,7 @@ void render_sigset_t(struct seq_file *m, const char *header, > if (sigismember(set, i+2)) x |= 2; > if (sigismember(set, i+3)) x |= 4; > if (sigismember(set, i+4)) x |= 8; > - seq_printf(m, "%x", x); > + seq_putc(m, hex_asc[x]); > } while (i >= 4); > > seq_putc(m, '\n'); > -- > 2.1.4 >