Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755150AbcKJCIk (ORCPT ); Wed, 9 Nov 2016 21:08:40 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:51003 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753269AbcKJCIj (ORCPT ); Wed, 9 Nov 2016 21:08:39 -0500 Message-ID: <1478743690.19253.4.camel@mtksdaap41> Subject: Re: [PATCH 4/4] dts: arm64: enable mmc3 for supporting sdio feature From: Yingjoe Chen To: Yong Mao CC: Ulf Hansson , Mark Rutland , , YH Huang , Nicolas Boichat , "Mathias Nyman" , , Catalin Marinas , , Will Deacon , Douglas Anderson , , Chunfeng Yun , Rob Herring , Geert Uytterhoeven , , Philipp Zabel , Matthias Brugger , , Eddie Huang , Chaotian Jing Date: Thu, 10 Nov 2016 10:08:10 +0800 In-Reply-To: <1478585341-6749-5-git-send-email-yong.mao@mediatek.com> References: <1478585341-6749-1-git-send-email-yong.mao@mediatek.com> <1478585341-6749-5-git-send-email-yong.mao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3819 Lines: 147 On Tue, 2016-11-08 at 14:09 +0800, Yong Mao wrote: > From: yong mao > > Add description of mmc3 for supporting sdio feature > > Signed-off-by: Yong Mao > Signed-off-by: Chaotian Jing > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 82 +++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > index 2a7f731..4dbd299 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > @@ -43,6 +43,14 @@ > enable-active-high; > }; > > + sdio_fixed_3v3: fixedregulator@0 { This should be regulator@1 instead of fixedregulator. > + compatible = "regulator-fixed"; > + regulator-name = "3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 85 GPIO_ACTIVE_HIGH>; > + }; > + > connector { > compatible = "hdmi-connector"; > label = "hdmi"; > @@ -139,6 +147,25 @@ > vqmmc-supply = <&mt6397_vmc_reg>; > }; > > +&mmc3 { > + status = "okay"; > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc3_pins_default>; > + pinctrl-1 = <&mmc3_pins_uhs>; > + bus-width = <4>; > + max-frequency = <200000000>; > + cap-sd-highspeed; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + sdr104-clk-delay = <5>; > + keep-power-in-suspend; > + enable-sdio-wakeup; > + cap-sdio-irq; > + vmmc-supply = <&sdio_fixed_3v3>; > + vqmmc-supply = <&mt6397_vgp3_reg>; > + non-removable; > +}; > + > &pio { > disp_pwm0_pins: disp_pwm0_pins { > pins1 { > @@ -197,6 +224,36 @@ > }; > }; > > + mmc3_pins_default: mmc3default { Please keep nodes in &pio sorted, move this one after mmc1_pins_uhs. > + pins_dat { > + pinmux = , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + pins_cmd { > + pinmux = ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + pins_clk { > + pinmux = ; > + bias-pull-down; > + drive-strength = ; > + }; > + > + pins_pdn { > + pinmux = ; > + output-low; > + }; This one is used in regulator, not really an mmc pin. Also, you don't need to add node for gpio usage, request_gpio will set mode for you. So please remove pins_pdn node. > + }; > + > mmc0_pins_uhs: mmc0 { > pins_cmd_dat { > pinmux = , > @@ -243,6 +300,31 @@ > bias-pull-down = ; > }; > }; > + > + mmc3_pins_uhs: mmc3 { Please keep nodes in &pio sorted, move this one after mmc1_pins_uhs. Joe.C > + pins_dat { > + pinmux = , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + pins_cmd { > + pinmux = ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + pins_clk { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + }; > }; > > &pwm0 {