Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283AbcKJFyj (ORCPT ); Thu, 10 Nov 2016 00:54:39 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:57673 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbcKJFyh (ORCPT ); Thu, 10 Nov 2016 00:54:37 -0500 Subject: Re: [PATCH 1/2] skd: fix msix error handling To: Arnd Bergmann References: <20161109125555.1440353-1-arnd@arndb.de> CC: Christoph Hellwig , Mike Christie , Hannes Reinecke , Ming Lin , From: Jens Axboe Message-ID: Date: Wed, 9 Nov 2016 22:54:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161109125555.1440353-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BLUPR11CA0018.namprd11.prod.outlook.com (10.141.240.28) To DM5PR15MB1193.namprd15.prod.outlook.com (10.173.209.11) X-MS-Office365-Filtering-Correlation-Id: 978d596c-ed44-47a5-9226-08d4092e015c X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;2:ppzB2/PJ/Pl/geIDeCa2y+uTrZIcZVSdntfgQgtlJewb48ffEbzG6GGPLqo9WQdFJWGx/A4Cpr8m+IC8GmwH6OQJzD6YCkjEqfWHCJ5icCqeOUkh3H3gYB3RzRzJ15D7/duDSZ3cXKO0OwtgaOtuJ+gHujjUo3n+cUdpVNgKRtpU925fUI4Bev2QMzG/QYyjduRuhkuACQAHkzkGpXM8ig==;3:6nfoIKh/0V66MoCdsZoLuaVgwwj8jsF45RwInTULFpJWF11XwQc6vrxJ7N12yOXEgaussjL7YACkAi4fNjgegxFQKzSiAwUM0MGVRSd1R3X0uO0laL/Y2C6h1fliB58y7mHQXsicmrOO9ADo/13JqQ==;25:5tURWbcPRuDrtvddBVsfY8z1Fj+G+hs/NVK1Z2rKNF/lSlnvdvhsR9rXbWCW4ELhC5wuBSAXPp8zs0+NIiRCu3ijC8ib9o7Nr9CpSROYJaEKHptSlYlgCUmkqx5ptSDv8iszmYjiry9uNRC4ZxmBRFtDtKT9ZbJJs27HJ+AUMfdsNiczZHAlzkpqDrqhli2j6Dex9sPmC69o77EAKFYNvV0CBkCPs2gImQottFAa0OnyvU258gCqd4t0r2H0tAzw1w5CbHZKh/x0rjMB8kL2QURtolWC5QbzFY+GDGv/nzwjWRLfcaWiffv6VMCRHqdpCOb8t9LZzqIoBSk3pSEh5/se/6/w1vV78AZF+HSufA2Jw1bP7nSQNqq7AVq4jutV/6A40AxGMIAOYLsACniL3W83T2EvBgmIW4KdTx8XOSk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1193; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;31:dezYBeOcJGrIhrUqKm0ti8smlCv9+b4+eCVcnkTnlV3EX1rsStdwgb65epw75HI/qKtjwH95CNSMFVyHloL8UqMJ2db5WwoffJciYcBBv7wDZio5b0Ck8RpRHdLxDgYYj+y1I8NVUBi5DHbM1Jq6L5lWLQ4SYQETpJa4FGS5kLJx7L+0ZGWl3aj5wApWpewTLnUnPZr1w0zeD9HWxDpwpo8QmfEhdiO+d9Exp/VWlGalCEj1iSWc8TvGKU5IHphE;20:76Lq0Z7Z2Nl3sH/RVal7LQZdvh/a51wRlzFYsAeDh9tKG+LmLUUxu0FvRr0WqKiPcSMKDliT4zHz0++o5VQlTA4CTYixe/8qDdcLoTiIV3zsDzWym2CBY9W+fJ6bFzZhsIJZWi6kCrPnTnoDFpZWXulHIdlnbiuoMDFL1PWup6c=;4:rQthyvae/0eIxbXJxraTH9KuojQj/SsSqDnn6aymbbSVqcwtK78IF4yl7U7Q29KXi2EPtThOa+vUb+3dVIN16pgnIou/9XWiY2alqLtmlFTIpdeAeYl8xWOST6eBz52xJ7dCvjkzPCaJK0UlY4DsyQJRErHGT/Am6NRvJVuB63K6Wat4dbEeWSTqWhFmOmwPgNx4N1xzkoxRUYl/4Z+QH51YVWX05haLl8z+XHVtW/+sOFiO8NnwK+NITxkeu+vD4rBdQV49l9tVytwWd5J/AEQpbVlBOGFPJa1127gIN1ls4Bap0lLpjYAPVsxe6vvpF/fn7+ORysOQ+0BYcPrebCdBQakQUHFbDvU5iHyrCGlhkrRnzbZ+/WTHH38YV/+1Wrf60OvDk1ibgqVt1I6bkg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM5PR15MB1193;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1193; X-Forefront-PRVS: 01221E3973 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(24454002)(377454003)(199003)(110136003)(64126003)(33646002)(3846002)(5660300001)(65826007)(6666003)(6916009)(2950100002)(23676002)(4001350100001)(4326007)(229853002)(50986999)(2906002)(8676002)(81156014)(586003)(54356999)(81166006)(76176999)(305945005)(7846002)(7736002)(6116002)(101416001)(83506001)(68736007)(86362001)(31696002)(2870700001)(189998001)(92566002)(77096005)(97736004)(42186005)(31686004)(105586002)(36756003)(106356001)(65806001)(66066001)(65956001)(47776003)(50466002)(117156001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1193;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMTkzOzIzOnUzL3JUYVlLKzluY0Z5REtkMU5QTXlPcUk5?= =?utf-8?B?TUlEM2ZOOWFUVUVPOHNaMU91aDZKeW0zcTBJYm56SmxxQzc4cGZrUXFPRnhn?= =?utf-8?B?K1B6TFkwZkpHK2o3Z0Q4S0FYMkg1QzloSW5Lc1JUZ1Ayd3h5WCt2MHFXZjJD?= =?utf-8?B?eVpTYlJJb2ZCTjFmaFdKaEU5clJyWHA4YTFQelJhMzdCd3VHeGM1UVpieVpV?= =?utf-8?B?Z0VsdGFVWVBVWGpZYjF2TmJ2Sk1VaUZyM0RPN3VLSkZoRk9kUUplVmRQQmNY?= =?utf-8?B?bU93NDFNNXI4cnFhTmhnVitZczdiRThpUzRybFNRYW1GcStpSzVUNWZwejNo?= =?utf-8?B?YXF6VzFleXBqakEzZWlxS1hHbWZjcmJnb2xQeTc2MWhpblI2amh5eXRiVURH?= =?utf-8?B?SlpJU1NBYmZhQTVmbjVTV3VEUlJMTGIwS0pjVVNBcHdOVCtUZkNTcGtVZDdU?= =?utf-8?B?TzJmdkk2YXY2QmtlSXBNTCs4dHJDWkYvNGdJY2tDbzlKNm1SU1NLRG10cFlj?= =?utf-8?B?Tm9XVjZQdzNNbDExL1MwNWZCU09Hb2FOS25VYXI1T3JoUmpQMzVVU0RncHFt?= =?utf-8?B?dm5vOUFmVS91UDJBVkdLcTJneHpFNFRqWWNNSkNpaE5ncGwzangyZVJUZkRP?= =?utf-8?B?b3JkdHd6Rk5YOWVyT2krMDBkQitvSTFER09vNnhaNlFFc3RjdXhoTlluWXB6?= =?utf-8?B?VWozV0xBSWF6bks4dm9pVXQyMzAzZ3FuQmxpZmkxcktRTlJrMU10NjZrSVJw?= =?utf-8?B?MEdJcUJVTW5kc1psbUtWY1JTN0FOdmUyK3lMMnNUbTJSU1ozWDVuUDlaTUdG?= =?utf-8?B?ckQ0RXArb1pEdmRxVGN3b3ZtbmdSbnE1MTczRHFFTjV0SkxQSlBzYmV0Z20r?= =?utf-8?B?QzdobzkzdEpTN2g5UkVWcklNNTUwUk1KRndOU09OZEtKUnBVY2RnT0hqYUFF?= =?utf-8?B?Ulhxakc0RnpMY0lqQWNBT2FlVXdtOGVXNTI0Y0Q0ZE54L2pIOW5TbGxQYjlS?= =?utf-8?B?UHhySTQxSjlxeTQybUx2TlVreXBHSFM4UStQRkxxVzh6UU5iYmQzNjZTRWdq?= =?utf-8?B?bFFBMzFlVy9MZ1RwOWwycWp4ZnVEemllVFZjTHlzenRVR3M1Sk1LeFdBZWI5?= =?utf-8?B?aVllWW92WHdGbWJhUFJEVjRrRXBOa04xUTI5Y2k4MzRsOHlCK0VDaVRncWhv?= =?utf-8?B?S2p2SW85ZWFjcnQ1R0F3L2RtMytCNFRpQytVaGYycFRuMnRHays3WjZ4dUtX?= =?utf-8?B?ZHlGSjlJYVErMDF3am1tN0pWQUxYWTVnVkFQSmtjSEJmVjBwY2t5UDN6UE1u?= =?utf-8?B?YjM0cVR6ek9oak14czlKZDd0YXVoT2prcXNSQlBTN29MdXRHVlRMWXYxRE5m?= =?utf-8?B?bkRPdXljV1ZsYXh0M3Urb3FVVHJhblZ2dHZCSDdseGVIa2x6cnp2T0ZabjZq?= =?utf-8?B?QUhwcWVWUUhJYVc0NnY2Z1ZPS3FHMzI3RzIydXpuZ0VGUmJ2ZHkveDJqSVBQ?= =?utf-8?B?SFhMczBFVGZ4VGRmOGJkSzBVVE82QW5CYlVRTUVBbFlRWGYrYTFDQTgvcmNI?= =?utf-8?B?d0dTUXlSdG1SZ2I2TXFiOXlWYXZxdU02eklhZGV5cGJuV1JBd3pmRUxiazhj?= =?utf-8?B?b1MvemtBTXZoUE40L1RFUEFOdXQ2bnRUaEpMODUza0VyQ3B1cVZWZEY5dVFV?= =?utf-8?B?K2ZscCtlWk5OS1NEUHY0cExCcDJRRS9iU040bGRiSVliYVZBS2VST0o3MWdE?= =?utf-8?Q?S7Nh3NTUt2A3ZxYgdOuHadl1Cts47opGzBEXc=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;6:4s7uyqqX26LgWe8azOkgrAOMP9wsCppt1OoTE6aDzxeA5rzB9eZ+2ORi2sFbekWker5K/J15ZeEq5OEQo1IkJ/wwe7Ff18Gg8EExHDSy2KaN6xvbPk/AjmRkDqDNnXVPvoIIW6R9DkaohxT2WVmoGdLZuvwxQBJGfpK62CQfRUUjpi/08m5pO4MTXcFJeEQs3OPlCITBPTWSVH07ZPeaCs3KL+vc4zu3lM6PjqRDZs7MPb4GY6hbW1XDYY7Mw3X7TdyNR0SeMpKVRWwLa1SPvK7Ugbo0Kw+whQ1z58VRfg8R1HEyIqbb/Pt8Ezki5vnf;5:02TsRi0USECyYusquImzg4CrSMzZr/WvtDfTrxZyj2xN3BB06g6eKM6zWNSABzcEvIDsOC70k5eyYmQgiR4mIb1/I5RsteQMnabnLxlGKGDgbMvfSQsXkRWinsMvdn4eHxHHQKRzLcJKIq4o+NqbJQ==;24:nlUXIxBchUUhWRniAUQT5HYvpNJiswHxA3KXhiVFftRyfkWPQAuKxI1jct84ehtAKeuoSsSAHS/PuQGMBEcsD9ZuokPpRcDCxB3PTbKnV3U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;7:OU8WG5ByuOhfPvUTFrZKATQexEp0AXqiieGyH/uwPjpm4jlyWty/wwklJ31woMCejwqIKZB7kigurP83/BJI+UfLqbUnkV5xgKJeeG5Onml0eLmBegHHsoGm0mXYkbYB0xmMA4CMR6JjjBVX5nRBqLN3KABxXxyntcxrvuFBOrBRZa3NiqxTzw3lKF1pxMsLQ3eOg16pr8JRhZ6mGq/Oid4j0IpxiNbI31T9z8B9tTJvTm+0r/gy2hAzsuvGMvb6dGXOAhHMLE0tTC0sW+PxbvRe88PCkSwYFO5ToRB9jeRurDjZ/LOPCbnJDKg5EKjdMG/OCqPFxwrSF6YrQSs7qVv0au+MLqzSrPNW2FVOV90=;20:ytvI/ID2SLs25zYX4rNqOfxtqe770WtBA8H/y2IFANp3SI6xP5H9oE+OF71D3STgt7GYGXxQxzpIdNVccriAQub2nrOQ1TFAvX+TPgdrA51okRBxyq/KfsggSSjbnlEYO8lwIDCNvtDM3/hu+vv2axiwFAOGCq+21aiKyHTjSFc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2016 05:54:11.7985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1193 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-10_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 16 On 11/09/2016 05:55 AM, Arnd Bergmann wrote: > As reported by gcc -Wmaybe-uninitialized, the cleanup path for > skd_acquire_msix tries to free the already allocated msi-x vectors > in reverse order, but the index variable may not have been > used yet: > > drivers/block/skd_main.c: In function ‘skd_acquire_irq’: > drivers/block/skd_main.c:3890:8: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This changes the failure path to skip releasing the interrupts > if we have not started requesting them yet. Applied both patches, thanks Arnd. -- Jens Axboe