Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbcKJFzO (ORCPT ); Thu, 10 Nov 2016 00:55:14 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:32856 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753412AbcKJFzL (ORCPT ); Thu, 10 Nov 2016 00:55:11 -0500 Date: Wed, 9 Nov 2016 21:55:07 -0800 From: Bjorn Andersson To: Stephen Boyd Cc: Sarangdhar Joshi , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jordan Crouse , Trilok Soni Subject: Re: [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency Message-ID: <20161110055507.GD11179@tuxbot> References: <1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-3-git-send-email-spjoshi@codeaurora.org> <20161110014718.GY16026@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110014718.GY16026@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 50 On Wed 09 Nov 17:47 PST 2016, Stephen Boyd wrote: > On 11/03, Sarangdhar Joshi wrote: > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > > index d79fecd..844e90d 100644 > > --- a/drivers/firmware/qcom_scm.c > > +++ b/drivers/firmware/qcom_scm.c > > @@ -380,32 +384,40 @@ EXPORT_SYMBOL(qcom_scm_is_available); > > static int qcom_scm_probe(struct platform_device *pdev) > > { > > struct qcom_scm *scm; > > + uint32_t clks; > > If this was unsigned long flags; > I did look at this too and could only find a mixture of ways people have done this. Isn't the correct type for this intptr_t? Regards, Bjorn > > int ret; > > > > scm = devm_kzalloc(&pdev->dev, sizeof(*scm), GFP_KERNEL); > > if (!scm) > > return -ENOMEM; > > > > - scm->core_clk = devm_clk_get(&pdev->dev, "core"); > > - if (IS_ERR(scm->core_clk)) { > > - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) > > - return PTR_ERR(scm->core_clk); > > + clks = (uint32_t)((uintptr_t)of_device_get_match_data(&pdev->dev)); > > then this could just be a cast to unsigned long? > > > + if (clks & SCM_HAS_CORE_CLK) { > > + scm->core_clk = devm_clk_get(&pdev->dev, "core"); > > + if (IS_ERR(scm->core_clk)) { > > + if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) > > + return PTR_ERR(scm->core_clk); > > > > - scm->core_clk = NULL; > > + scm->core_clk = NULL; > > + } > > } > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project