Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcKJGiP (ORCPT ); Thu, 10 Nov 2016 01:38:15 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:28531 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcKJGiN (ORCPT ); Thu, 10 Nov 2016 01:38:13 -0500 X-Greylist: delayed 5419 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Nov 2016 01:38:13 EST Subject: Re: [PATCH] drivers: mfd: ti_am335x_tscadc: increase ADC ref clock to 24MHz To: John Syne References: <20161024060226.4170-1-mugunthanvnm@ti.com> <038C6B01-8443-4321-9C65-BAC4095237D3@gmail.com> <086ab2fa-63ee-c5ab-2715-b2efd78270d7@ti.com> <12725C92-9BB8-4F77-A7B4-F3C3DA9F8B0B@gmail.com> <20161025063847.GD8574@dell> <20161026084811.GI8574@dell> CC: Lee Jones , "N, Mugunthan V" , "linux-iio@vger.kernel.org" , Tony Lindgren , Jonathan Cameron , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Nori, Sekhar" , "Ujfalusi, Peter" From: Vignesh R Message-ID: Date: Thu, 10 Nov 2016 10:37:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 32 Hi, On Thursday 10 November 2016 05:23 AM, John Syne wrote: > OK, then back to my original question. Given that these DT properties are supported in the driver > Below properties are supported by only by ti_am3335x_adc driver and not ti_am335x_tsc driver. As author of this patch pointed out in another reply, there is no need to change step-opendelay for tsc. AFAIK, I don't see a use case where these values needs to be tweaked for tsc channels, therefore it does not make sense to be DT properties. > shouldn’t the following be added to am33xx.dtsi and am4372.dtsi? Its totally upto board dts files to allocate channels for tsc and adc. So, how could these be added to dtsi files? > ti,chan-step-avg = <0x16 0x16 0x16 0x16 0x16 0x16 0x16>; > ti,chan-step-opendelay = <0x500 0x500 0x500 0x500 0x500 0x500 0x500>; > ti,chan-step-sampledelay = <0x0 0x0 0x0 0x0 0x0 0x0 0x0>; > > Regards, > John >> >> -- >> Regards >> Vignesh > -- Regards Vignesh