Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754938AbcKJJP3 convert rfc822-to-8bit (ORCPT ); Thu, 10 Nov 2016 04:15:29 -0500 Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:48288 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754747AbcKJJP1 (ORCPT ); Thu, 10 Nov 2016 04:15:27 -0500 From: Naoya Horiguchi To: Anshuman Khandual CC: "linux-mm@kvack.org" , "Kirill A. Shutemov" , Hugh Dickins , "Andrew Morton" , Dave Hansen , Andrea Arcangeli , Mel Gorman , Michal Hocko , "Vlastimil Babka" , Pavel Emelyanov , Zi Yan , Balbir Singh , "linux-kernel@vger.kernel.org" , "Naoya Horiguchi" Subject: Re: [PATCH v2 07/12] mm: thp: check pmd migration entry in common path Thread-Topic: [PATCH v2 07/12] mm: thp: check pmd migration entry in common path Thread-Index: AQHSOVF91G9mSKw0IEiSF7PKRh5xwqDRUXsAgAAKB4A= Date: Thu, 10 Nov 2016 09:12:07 +0000 Message-ID: <20161110091207.GB9173@hori1.linux.bs1.fc.nec.co.jp> References: <1478561517-4317-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1478561517-4317-8-git-send-email-n-horiguchi@ah.jp.nec.com> <5824317E.5050706@linux.vnet.ibm.com> In-Reply-To: <5824317E.5050706@linux.vnet.ibm.com> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.28] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <58C392E89D5DC34697BDE30F50987D1F@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 16 On Thu, Nov 10, 2016 at 02:06:14PM +0530, Anshuman Khandual wrote: > On 11/08/2016 05:01 AM, Naoya Horiguchi wrote: > > If one of callers of page migration starts to handle thp, memory management code > > start to see pmd migration entry, so we need to prepare for it before enabling. > > This patch changes various code point which checks the status of given pmds in > > order to prevent race between thp migration and the pmd-related works. > > There are lot of changes in this one patch. Should not we split > this up into multiple patches and explain them in a bit detail > through their commit messages ? Yes, and I admit that I might change more than necessary, if the context never encounters migration entry for any reason, no change is needed. I'll dig more detail. - Naoya Horiguchi