Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615AbcKJKBJ (ORCPT ); Thu, 10 Nov 2016 05:01:09 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:56762 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbcKJKBG (ORCPT ); Thu, 10 Nov 2016 05:01:06 -0500 X-AuditID: cbfee61b-f796f6d000004092-75-5824455d0243 From: Shailendra Verma To: Jarod Wilson , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Shailendra Verma , Shailendra Verma Cc: linux-kernel@vger.kernel.org, vidushi.koul@samsung.com Subject: [PATCH] Staging: Media: Lirc - Improvement in code readability Date: Thu, 10 Nov 2016 15:28:38 +0530 Message-id: <1478771918-1690-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t9jAd1YV5UIg78vTC32nPnFbtG8eD2b xdUXJ5gsLu+aw2bRs2Erq8XqZxUWt+bNZLNY9O0Vs8Xfi5fYHDg97u07zOKxc9Zddo/9c9ew e2zpB7L6tqxi9Pi8Sc5j6sk+1gD2KDebjNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFul CF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhl3Dr4jLVgP0/F478rWBsYj3N1MXJySAiYSPQ1 /2GGsMUkLtxbz9bFyMUhJLCUUeLpj+ksEM5PRokJd9YxgVSxCRhKvO77ywSSEBFYwSQxZ2Er O0iCWcBKYtL/2awgtrCAu8T9/w1ANgcHi4CqxOUH3CBhXqBwx539LCBhCQEFiTmTbCYwci9g ZFjFKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJERzIz6R3MB7e5X6IUYCDUYmH16JSOUKI NbGsuDL3EKMEB7OSCK+qo0qEEG9KYmVValF+fFFpTmrxIUZToPUTmaVEk/OBUZZXEm9oYm5i bmxgYW5paWKkJM7bOPtZuJBAemJJanZqakFqEUwfEwenVAPj7AlTSsW2GXduOnv7ybqEG/Yb Krx13q0/W1S0Pv1g0yneegVJ95WFOrXWB48cd7a4rRVjbSNyZvYKE75/988WP/vzVlnX+bjs e/VPPxWNuuuv+LisY8h+dvnN44KvnBVHDlUpLhGZpnQ1j+NcVOX1cI4TF1xPTV28+ObtowG3 OXuvKgmFWheVKLEUZyQaajEXFScCAGGT6Lh6AgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 45 From: "Shailendra Verma" There is no need to call kfree() if memdup_user() fails, as no memory was allocated and the error in the error-valued pointer should be returned. Signed-off-by: Shailendra Verma --- drivers/staging/media/lirc/lirc_imon.c | 5 ++--- drivers/staging/media/lirc/lirc_sasem.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 198a805..610d38c 100644 --- a/drivers/staging/media/lirc/lirc_imon.c +++ b/drivers/staging/media/lirc/lirc_imon.c @@ -408,9 +408,8 @@ static ssize_t vfd_write(struct file *file, const char __user *buf, data_buf = memdup_user(buf, n_bytes); if (IS_ERR(data_buf)) { - retval = PTR_ERR(data_buf); - data_buf = NULL; - goto exit; + mutex_unlock(&context->ctx_lock); + return PTR_ERR(data_buf); } memcpy(context->tx.data_buf, data_buf, n_bytes); diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c index 4678ae1..4fd810b 100644 --- a/drivers/staging/media/lirc/lirc_sasem.c +++ b/drivers/staging/media/lirc/lirc_sasem.c @@ -384,9 +384,8 @@ static ssize_t vfd_write(struct file *file, const char __user *buf, data_buf = memdup_user(buf, n_bytes); if (IS_ERR(data_buf)) { - retval = PTR_ERR(data_buf); - data_buf = NULL; - goto exit; + mutex_unlock(&context->ctx_lock); + return PTR_ERR(data_buf); } memcpy(context->tx.data_buf, data_buf, n_bytes); -- 1.7.9.5