Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755013AbcKJKCJ (ORCPT ); Thu, 10 Nov 2016 05:02:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:46981 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754883AbcKJKCF (ORCPT ); Thu, 10 Nov 2016 05:02:05 -0500 X-AuditID: cbfee61a-f79916d0000062de-22-5824459b7acc Date: Thu, 10 Nov 2016 19:02:03 +0900 From: Andi Shyti To: Jacek Anaszewski Cc: Rob Herring , Mauro Carvalho Chehab , Sean Young , Mark Rutland , Richard Purdie , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver Message-id: <20161110100203.2qv6j6acywpjerfi@gangnam.samsung> References: <20161102104010.26959-1-andi.shyti@samsung.com> <20161102104010.26959-6-andi.shyti@samsung.com> <70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com> <20161103101048.ofyoko4mkcypf44u@gangnam.samsung> <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> <20161109182621.ttfxtdt32q3cqce7@rob-hp-laptop> <13210179-ea3f-6106-e3c0-fa30b83e23cc@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <13210179-ea3f-6106-e3c0-fa30b83e23cc@samsung.com> User-Agent: NeoMutt/20161014 (1.7.1) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAd3ZrioRBm83G1vMP3KO1aL36nNG i8u75rBZbH2zjtGiZ8NWVoul1y8yWax+VmHxf88Odovdu56yWix8+p3Fgctjzbw1jB6bVnWy eSx5Y+2xpf8uu8ee+T9YPfq2rGL0+LxJLoA9ys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkh LzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Z3zrbWQsu8lTcPviUqYHxPGcXIyeH hICJRNexhYwQtpjEhXvr2boYuTiEBJYySrz7cJkVwvnIKLFk2xk2kCoWAVWJlUd2sYPYbAKa Ek23f4DFRQT0JRoa+hhBGpgFNjFJHP9yBKxIWCBR4sbZo6wgNq+ArcSzzXtZIKYeY5bYdu04 O0RCUOLH5HssIDazgJbE+p3HmSBsaYlHf2eA1XAK2Ets7PwLViMqoCIx6/IclgmMArOQtM9C 0j4LSfsCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMFx+UxqB+PBXe6HGAU4GJV4 eDs0lSOEWBPLiitzDzFKcDArifCqOqpECPGmJFZWpRblxxeV5qQWH2I0BQbJRGYp0eR8YMrI K4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qB8dhH7lut0/tKVaod VzmvmNu93jzckbFOpaLDKDNfviAqgFPltIXMxRaXKz/9l+jlXd2zLipuY6/JOwX+JN6ntf+O rZtctHsxZ/4rIbFm/oPeth+L18oe2VSTrtE87e7vlmn7fi7bq6FTUp1lYJcddeSAxeGb2wJv XhDwy4hVv28hxbi4+MdBJZbijERDLeai4kQAIDe03OECAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 43 Hi Jacek, > > > > > Only DT bindings of LED class drivers should be placed in > > > > > Documentation/devicetree/bindings/leds. Please move it to the > > > > > media bindings. > > > > > > > > that's where I placed it first, but Rob asked me to put it in the > > > > LED directory and Cc the LED mailining list. > > > > > > > > That's the discussion of the version 2: > > > > > > > > https://lkml.org/lkml/2016/9/12/380 > > > > > > > > Rob, Jacek, could you please agree where I can put the binding? > > > > > > I'm not sure if this is a good approach. I've noticed also that > > > backlight bindings have been moved to leds, whereas they don't look > > > similarly. > > > > > > We have common.txt LED bindings, that all LED class drivers' bindings > > > have to follow. Neither backlight bindings nor these ones do that, > > > which introduces some mess. > > > > And there are probably LED bindings that don't follow common.txt either. > > > > > Eventually adding a sub-directory, e.g. remote_control could make it > > > somehow logically justified, but still - shouldn't bindings be > > > placed in the documentation directory related to the subsystem of the > > > driver they are predestined to? > > > > No. While binding directories often mirror the driver directories, they > > are not the same. Bindings are grouped by types of h/w and IR LEDs are a > > type of LED. > > > > If you prefer a sub-dir, that is fine with me. > > Fine. So how about sub-dir "ir" ? would we put here all the remote control bindings that currently are under media? Thanks, Andi