Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755099AbcKJKee (ORCPT ); Thu, 10 Nov 2016 05:34:34 -0500 Received: from foss.arm.com ([217.140.101.70]:45356 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755029AbcKJKed (ORCPT ); Thu, 10 Nov 2016 05:34:33 -0500 Subject: Re: [PATCH] drivers: cpuidle: assign enter_freeze to same as enter callback function To: Vincent Guittot References: <1478713410-10727-1-git-send-email-sudeep.holla@arm.com> <20161109183925.GA19565@red-moon> Cc: Sudeep Holla , Lorenzo Pieralisi , "linux-pm@vger.kernel.org" , "Rafael J . Wysocki" , linux-kernel , Daniel Lezcano , Andy Gross From: Sudeep Holla Organization: ARM Message-ID: <8ab8322f-dcc8-d60e-3839-05ebedb6ffbc@arm.com> Date: Thu, 10 Nov 2016 10:34:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 30 On 10/11/16 10:28, Vincent Guittot wrote: > On 9 November 2016 at 19:48, Sudeep Holla wrote: >> >> >> On 09/11/16 18:39, Lorenzo Pieralisi wrote: [..] >>> I would just init the enter_freeze() pointer and be done with that, >>> adding code to check whether the idle back-end enables IRQs when it >>> enters idle is a major PITA that really is not worth the hassle and >>> apart from coupled C-states (which we do not support in DT as you said) >>> I can't find another example (and on top of that it is not even >>> something we can solve through DT since it is not a property of the idle >>> state but more related to its kernel implementation). >>> >> >> Makes sense, I was just trying to avoid setting for a state like >> CPU/Cluster retention but I agree, we need not do that. > > I agree with Lorenzo and would prefer to keep it simple > Sure I will respin accordingly. -- Regards, Sudeep