Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904AbcKJKpG (ORCPT ); Thu, 10 Nov 2016 05:45:06 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36457 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbcKJKpE (ORCPT ); Thu, 10 Nov 2016 05:45:04 -0500 Date: Thu, 10 Nov 2016 11:45:01 +0100 From: Borislav Petkov To: He Chen Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Luwei Kang , Piotr Luc Subject: Re: [PATCH v5 1/3] cpuid: cleanup cpuid_regs definitions Message-ID: <20161110104501.rl7cyjf56fdvusyj@pd.tnic> References: <1478689528-444-1-git-send-email-he.chen@linux.intel.com> <1478689528-444-2-git-send-email-he.chen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1478689528-444-2-git-send-email-he.chen@linux.intel.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2096 Lines: 53 On Wed, Nov 09, 2016 at 07:05:26PM +0800, He Chen wrote: > make cpuid_regs more clear and avoid potential name clash. > > Signed-off-by: He Chen Btw, please name your subjects like this: x86/cpuid: Cleanup ... Also the name should be a complete sentence starting with a capital letter. The last patch, the 3/3 should be called something like "x86/kvm: ..." or so. ... > @@ -31,14 +24,14 @@ void init_scattered_cpuid_features(struct cpuinfo_x86 *c) > const struct cpuid_bit *cb; > > static const struct cpuid_bit cpuid_bits[] = { > - { X86_FEATURE_INTEL_PT, CR_EBX,25, 0x00000007, 0 }, > - { X86_FEATURE_AVX512_4VNNIW, CR_EDX, 2, 0x00000007, 0 }, > - { X86_FEATURE_AVX512_4FMAPS, CR_EDX, 3, 0x00000007, 0 }, > - { X86_FEATURE_APERFMPERF, CR_ECX, 0, 0x00000006, 0 }, > - { X86_FEATURE_EPB, CR_ECX, 3, 0x00000006, 0 }, > - { X86_FEATURE_HW_PSTATE, CR_EDX, 7, 0x80000007, 0 }, > - { X86_FEATURE_CPB, CR_EDX, 9, 0x80000007, 0 }, > - { X86_FEATURE_PROC_FEEDBACK, CR_EDX,11, 0x80000007, 0 }, > + { X86_FEATURE_INTEL_PT, CPUID_EBX,25, 0x00000007, 0 }, > + { X86_FEATURE_AVX512_4VNNIW, CPUID_EDX, 2, 0x00000007, 0 }, > + { X86_FEATURE_AVX512_4FMAPS, CPUID_EDX, 3, 0x00000007, 0 }, > + { X86_FEATURE_APERFMPERF, CPUID_ECX, 0, 0x00000006, 0 }, > + { X86_FEATURE_EPB, CPUID_ECX, 3, 0x00000006, 0 }, > + { X86_FEATURE_HW_PSTATE, CPUID_EDX, 7, 0x80000007, 0 }, > + { X86_FEATURE_CPB, CPUID_EDX, 9, 0x80000007, 0 }, > + { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX,11, 0x80000007, 0 }, ERROR: space required after that ',' (ctx:VxV) #150: FILE: arch/x86/kernel/cpu/scattered.c:27: + { X86_FEATURE_INTEL_PT, CPUID_EBX,25, 0x00000007, 0 }, ^ ERROR: space required after that ',' (ctx:VxV) #157: FILE: arch/x86/kernel/cpu/scattered.c:34: + { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX,11, 0x80000007, 0 }, ^ -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.