Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755187AbcKJKps (ORCPT ); Thu, 10 Nov 2016 05:45:48 -0500 Received: from 8bytes.org ([81.169.241.247]:58250 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755152AbcKJKpr (ORCPT ); Thu, 10 Nov 2016 05:45:47 -0500 Date: Thu, 10 Nov 2016 11:45:44 +0100 From: Joerg Roedel To: David Woodhouse Cc: Xunlei Pang , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Mika Kuoppala Subject: Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table Message-ID: <20161110104544.GA2078@8bytes.org> References: <1473648551-10025-1-git-send-email-xlpang@redhat.com> <20160919121827.GB3541@8bytes.org> <1476274674.16627.173.camel@infradead.org> <1477829902.4154.9.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477829902.4154.9.camel@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 330 Lines: 15 Hi David, On Sun, Oct 30, 2016 at 06:18:22AM -0600, David Woodhouse wrote: > + /* Start at 2 because it's defined as 1^(1+PSS) */ This probably means 2^(1+PSS), right? > + iommu->pasid_max = 2 << ecap_pss(iommu->ecap); Otherwise the patch looks good. Do you want to send it upstream yourself or should I pick it up? Joerg