Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478AbcKJLdB (ORCPT ); Thu, 10 Nov 2016 06:33:01 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38996 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457AbcKJLc7 (ORCPT ); Thu, 10 Nov 2016 06:32:59 -0500 Date: Thu, 10 Nov 2016 07:06:44 +0100 From: Greg Kroah-Hartman To: Eugene Korenevsky , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement Message-ID: <20161110060644.GA28591@kroah.com> References: <20161109153521.GA20272@vnote> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161109153521.GA20272@vnote> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 14 On Wed, Nov 09, 2016 at 06:35:21PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Changes since v3: fix typo > Changes since v2: extract the code to static function > Changes since v1: fix spaces instead of tab, add missing 'Signed-off-by' changes go below the --- line, please read Documentation/SubmittingPatches for all of the details. thanks, greg k-h