Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755516AbcKJLj1 convert rfc822-to-8bit (ORCPT ); Thu, 10 Nov 2016 06:39:27 -0500 Received: from mga03.intel.com ([134.134.136.65]:53766 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbcKJLjZ (ORCPT ); Thu, 10 Nov 2016 06:39:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,618,1473145200"; d="scan'208";a="1066647477" From: "Levy, Amir (Jer)" To: Greg KH CC: "andreas.noever@gmail.com" , "bhelgaas@google.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "mario_limonciello@dell.com" , thunderbolt-linux , "Westerberg, Mika" , "Winkler, Tomas" , "Zhang, Xiong Y" Subject: RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking Thread-Topic: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking Thread-Index: AQHSOoO1E33Xz8/iJ0iynfF+yxmEQqDQrr2AgAFpIwA= Date: Thu, 10 Nov 2016 11:39:19 +0000 Message-ID: References: <1478701208-4585-1-git-send-email-amir.jer.levy@intel.com> <20161109160219.GB9111@kroah.com> In-Reply-To: <20161109160219.GB9111@kroah.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2604 Lines: 61 On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between computers, perform PC migrations, and/or set up small > > workgroups with shared storage. > > > > This is a virtual connection that emulates an Ethernet adapter that > > enables Ethernet networking with the benefit of Thunderbolt superfast > > medium capability. > > > > Thunderbolt Networking enables two hosts and several devices that have > > a Thunderbolt controller to be connected together in a linear (Daisy > > chain) series from a single port. > > > > Thunderbolt Networking for Linux is compatible with Thunderbolt > > Networking on systems running macOS or Windows and also supports > > Thunderbolt generation 2 and 3 controllers. > > > > Note that all pre-existing Thunderbolt generation 3 features, such as > > USB, Display and other Thunderbolt device connectivity will continue > > to function exactly as they did prior to enabling Thunderbolt Networking. > > > > Code and Software Specifications: > > This kernel code creates a virtual ethernet device for computer to > > computer communication over a Thunderbolt cable. > > The new driver is a separate driver to the existing Thunderbolt driver. > > It is designed to work on systems running Linux that interface with > > Intel Connection Manager (ICM) firmware based Thunderbolt controllers > > that support Thunderbolt Networking. > > The kernel code operates in coordination with the Thunderbolt user- > > space daemon to implement full Thunderbolt networking functionality. > > > > Hardware Specifications: > > Thunderbolt Hardware specs have not yet been published but are used > > where necessary for register definitions. > > > > Acked-by: Andreas Noever > > Tested-by: Mario Limonciello > > This whole series is acked and tested by these people? If so, why did you not > include that in each patch? > Will add in next patch set. > And how about getting some internal-Intel kernel developers to review and > sign-off on this code? Don't make the community do the review when you > have access to resources like this. You have an internal mailing list for this > very purpose, use it! > The review with the internal-Intel kernel developers was done before submitting the first patch set. Version 9 that we have here isn't so different from Version 0. > thanks, > > greg k-h