Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933584AbcKJOTT (ORCPT ); Thu, 10 Nov 2016 09:19:19 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51216 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933472AbcKJOTR (ORCPT ); Thu, 10 Nov 2016 09:19:17 -0500 Date: Thu, 10 Nov 2016 15:19:25 +0100 From: Greg Kroah-Hartman To: Chris Metcalf Cc: linux-kernel@vger.kernel.org, Paul Gortmaker , Arnd Bergmann Subject: Re: [PATCH] tile-srom: allow the driver to be built as a module Message-ID: <20161110141925.GA27818@kroah.com> References: <20161031174954.7924-1-paul.gortmaker@windriver.com> <1478552197-6845-1-git-send-email-cmetcalf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478552197-6845-1-git-send-email-cmetcalf@mellanox.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 20 On Mon, Nov 07, 2016 at 03:56:37PM -0500, Chris Metcalf wrote: > The code was already configured that way, but the Kconfig > file didn't support requesting it. > > A buglet caused a null pointer deref when unloading the > module, but this commit also corrects that issue. > > Signed-off-by: Chris Metcalf > --- > This is in response to Paul's patch (see the in-reply-to) suggesting > we remove the module infrastructure from the code instead. > > I can push this via the tile tree since it's a tile-only device, > or Greg, if you'd prefer to take it via your tree, that's fine too. I'll take it in mine, that's easy enough... thanks, greg k-h