Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933759AbcKJOZy (ORCPT ); Thu, 10 Nov 2016 09:25:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51694 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933132AbcKJOZw (ORCPT ); Thu, 10 Nov 2016 09:25:52 -0500 Date: Thu, 10 Nov 2016 15:25:59 +0100 From: Greg Kroah-Hartman To: Jakub Kicinski Cc: netdev@vger.kernel.org, Nicolai Stange , Christian Lamparter , LKML Subject: Re: [PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real_fops() Message-ID: <20161110142559.GA15902@kroah.com> References: <1478193129-23476-1-git-send-email-jakub.kicinski@netronome.com> <1478193129-23476-11-git-send-email-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478193129-23476-11-git-send-email-jakub.kicinski@netronome.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 34 On Thu, Nov 03, 2016 at 05:12:06PM +0000, Jakub Kicinski wrote: > seq_file users can only access const version of file pointer, > because the ->file member of struct seq_operations is marked > as such. Make parameter to debugfs_real_fops() const. > > CC: Greg Kroah-Hartman > CC: Nicolai Stange > CC: Christian Lamparter > CC: LKML > Signed-off-by: Jakub Kicinski > --- > include/linux/debugfs.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h > index 4d3f0d1aec73..bf1907d96097 100644 > --- a/include/linux/debugfs.h > +++ b/include/linux/debugfs.h > @@ -52,7 +52,8 @@ struct debugfs_regset32 { > * Must only be called under the protection established by > * debugfs_use_file_start(). > */ > -static inline const struct file_operations *debugfs_real_fops(struct file *filp) > +static inline const struct file_operations * > +debugfs_real_fops(const struct file *filp) Ick. Tell me that looks better :( Please just don't wrap things like that, just make it go longer than 80 columns, I can handle the complaints... thanks, greg k-h