Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933977AbcKJO4d (ORCPT ); Thu, 10 Nov 2016 09:56:33 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60112 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933831AbcKJO4c (ORCPT ); Thu, 10 Nov 2016 09:56:32 -0500 Date: Thu, 10 Nov 2016 15:56:30 +0100 From: Maxime Ripard To: Daniel Vetter , David Airlie , Thomas Petazzoni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Chen-Yu Tsai , Laurent Pinchart , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] drm/sun4i: Add support for the overscan profiles Message-ID: <20161110145630.wvzlh6rxusrufv2r@lukather> References: <20161108085927.ibyett46cjgyfwu2@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6dv23vtysmcnp63l" Content-Disposition: inline In-Reply-To: <20161108085927.ibyett46cjgyfwu2@phenom.ffwll.local> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2220 Lines: 61 --6dv23vtysmcnp63l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Daniel, On Tue, Nov 08, 2016 at 09:59:27AM +0100, Daniel Vetter wrote: > On Tue, Oct 18, 2016 at 10:29:38AM +0200, Maxime Ripard wrote: > > Create overscan profiles reducing the displayed zone. > >=20 > > For each TV standard (PAL and NTSC so far), we create 4 more reduced mo= des > > by steps of 5% that the user will be able to select. > >=20 > > Signed-off-by: Maxime Ripard >=20 > tbh I think if we agree to do this (and that still seems an open question) > I think there should be a generic helper to add these overscan modes with > increased porches. Anything that only depends upon the sink (and > overscanning is something the sink does) should imo be put into a suitable > helper library for everyone to share. >=20 > Or maybe even stash it into the probe helpers and call it for all TV > connectors. Definitely not a driver-private thing. Last time we discussed it, my recollection was that you didn't want to have generic code for it, but I'd be happy to implement it. I'll come up with something like that. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --6dv23vtysmcnp63l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYJIqaAAoJEBx+YmzsjxAgVjUP/A+qNG1VLckRMcLyp5HZgV+v jEmusTqxFID3axzdQrXj680EfzKQ0hRK5L4gu9vWzQMLIMzGytM6n6L/0kAg84y4 WIlvqxPCAPh25w437UX/wsvSR3QtsOBxlQ0Hshg22Rz9Ecrw2OQG8fca4q0NiJCG YsJewczy7fAabDnT6EGQ4wbuArfjnG7gsSHCknua2HWQXpodej9F+9ck36ZMBpCV Jd6Tkd5h+ZHrlku7V5Tb3F6oYBaWLIO4UV5ljaE4WwwbM3PZVRBHbLoOLd4V6HM/ LDNcHQm0jxaVv8LbI836ZrtVfPAuDB6lCWbTLvs8FTE19IpyGg8vKmxWUBBPxlYk MEP91QIBUWwGEo37Vlb0sC10SNv+zJBGbW5+1OvlQ19Lqc+FM+aPO5Ro9Fe4E7OG V72gU5RNhVZ/0WkozBdLHw2J5LMQ6OYX/4qQE6PyMVU2UIuQQPJtbW1/YOKjqNKo 3jlAOCF3LY8UiewJDJqjzNAGFnFVAn0dRpuHVZR4RWrTzEQGe8D5txnTt5y9hgW1 My8lcue0G56kMrzNF+I75vcYRsC8c6/MG7v1mV4AOEY9nxWBYQvB8zA/TrbiHPq9 Qf/LngVdNgz2NsGuvdFEFcOpaJsSvXT2IlcLXPgNbm4kzyYICmoBJ8iTNQ6EEanu Ppf0Dy1v8CKMxb+SVJwm =XUnW -----END PGP SIGNATURE----- --6dv23vtysmcnp63l--