Date: Thu, 10 Nov 2016 16:55:11 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Yves-Alexis Perez <corsac@corsac.net>, linux-kernel@vger.kernel.org,
        Yves-Alexis Perez <corsac@debian.org>,
        Ming Lei <ming.lei@canonical.com>,
        Johannes Berg <johannes@sipsolutions.net>, Jouni Malinen <j@w1.fi>,
        Kees Cook <keescook@chromium.org>, Jiri Kosina <jkosina@suse.cz>,
        Jiri Slaby <jslaby@suse.com>, Tom Gundersen <teg@jklm.no>,
        Kay Sievers <kay@vrfy.org>, Josh Boyer <jwboyer@fedoraproject.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Harald Hoyer <harald@redhat.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Daniel Wagner <wagi@monom.org>, stable@vger.kernel.org
Subject: Re: [PATCH] firmware: fix async/manual firmware loading
Message-ID: <20161110155511.GA10806@kroah.com>
References: <20161030145048.6291-1-corsac@corsac.net>
 <20161030145048.6291-2-corsac@corsac.net>
 <20161109203921.GH13978@wotan.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161109203921.GH13978@wotan.suse.de>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1323
Lines: 35

On Wed, Nov 09, 2016 at 09:39:21PM +0100, Luis R. Rodriguez wrote:
> On Sun, Oct 30, 2016 at 03:50:48PM +0100, Yves-Alexis Perez wrote:
> > From: Yves-Alexis Perez <corsac@debian.org>
> > 
> > wait_for_completion_interruptible_timeout() return value is either
> > -ERESTARTSYS (in case it was interrupted), 0 (in case the timeout expired)
> > or the number of jiffies left until timeout. The return value is stored in
> > a long, but in _request_firmware_load() it's silently casted to an int,
> > which can overflow and give a negative value, indicating an error.
> > 
> > Fix this by re-using the timeout variable and only set retval when it's
> > safe.
> 
> Please amend the commit log as I noted in the previous response, and
> resend.
> 
> > Signed-off-by: Yves-Alexis Perez <corsac@corsac.net>
> > Cc: Ming Lei <ming.lei@canonical.com>
> > Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Other than the commit log you can add on you resend:
> 
> Acked-by: Luis R. Rodriguez.
> 
> Modulo I don't personally thing this this is sable material but I'll let
> Greg decide.

Does it fix a regression?  A reported issue with an older kernel version
that people have hit?  It shouldn't be hard to figure out if a patch
should be in stable or not...

thanks,

greg k-h