Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935097AbcKJQgt (ORCPT ); Thu, 10 Nov 2016 11:36:49 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:34109 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934156AbcKJQgr (ORCPT ); Thu, 10 Nov 2016 11:36:47 -0500 Subject: Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing To: Olaf Hering References: <1447186233-3194-1-git-send-email-boris.ostrovsky@oracle.com> <20161110162633.GA5301@aepfle.de> Cc: konrad.wilk@oracle.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, xen-devel@lists.xen.org From: Boris Ostrovsky Message-ID: <0c993a89-83a1-d8a8-4927-d36660179256@oracle.com> Date: Thu, 10 Nov 2016 11:39:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110162633.GA5301@aepfle.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aFmjjgXCj8G16MPNlFbUbXVM7tLLA4QEd" X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3304 Lines: 98 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aFmjjgXCj8G16MPNlFbUbXVM7tLLA4QEd Content-Type: multipart/mixed; boundary="FGKB0fLKOpfUQ4A5ATnOMv0eEKgUhDEW1"; protected-headers="v1" From: Boris Ostrovsky To: Olaf Hering Cc: konrad.wilk@oracle.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, xen-devel@lists.xen.org Message-ID: <0c993a89-83a1-d8a8-4927-d36660179256@oracle.com> Subject: Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing References: <1447186233-3194-1-git-send-email-boris.ostrovsky@oracle.com> <20161110162633.GA5301@aepfle.de> In-Reply-To: <20161110162633.GA5301@aepfle.de> --FGKB0fLKOpfUQ4A5ATnOMv0eEKgUhDEW1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2016 11:26 AM, Olaf Hering wrote: > On Tue, Nov 10, Boris Ostrovsky wrote: Perfect timing. This is from Nov. 10 2015. > >> Doing so will cause the grant to be unmapped and then, during >> fault handling, the fault to be mistakenly treated as NUMA hint >> fault. >> >> In addition, even if those maps could partcipate in NUMA >> balancing, it wouldn't provide any benefit since we are unable >> to determine physical page's node (even if/when VNUMA is >> implemented). >> >> Marking grant maps' VMAs as VM_IO will exclude them from being >> part of NUMA balancing. > This breaks qdisk+aio because now such pages are rejected with -EFAULT:= Is this something new? Because this patch has been there for a year. -boris > > check_vma_flags > __get_user_pages > __get_user_pages_locked > __get_user_pages_unlocked > get_user_pages_fast > iov_iter_get_pages > dio_refill_pages > do_direct_IO > do_blockdev_direct_IO > do_blockdev_direct_IO > ext4_direct_IO_read > generic_file_read_iter > aio_run_iocb > > domU.cfg: > builder=3Dhvm > disk=3D['vdev=3Dxvda, direct-io-safe, backendtype=3Dqdisk, target=3Dimg= =2Eraw'] > >> @@ -802,7 +802,7 @@ static int gntdev_mmap(struct file *flip, struct v= m_area_struct *vma) >> - vma->vm_flags |=3D VM_DONTEXPAND | VM_DONTDUMP; >> + vma->vm_flags |=3D VM_DONTEXPAND | VM_DONTDUMP | VM_IO; > > Olaf --FGKB0fLKOpfUQ4A5ATnOMv0eEKgUhDEW1-- --aFmjjgXCj8G16MPNlFbUbXVM7tLLA4QEd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYJKKzAAoJEIredpCGysGyhpMQALEpWhkx/69MpM8b8XFewo35 f61qf9dvHTtfn6J800/i/bPUl+3EvU55eJczqn5CVWDU5jHJrt5Sr14VQ/uX9WPf vSg23rJfnodvsEOLJAqVwYksyNyF56HbdZFzpFkfNa5Hev3lpoExkp8q73dqM5IO 7j2sCpnBP03HdlYrdws9HsK488bq13ATJKEr1aXeGUE5nIgsc77PyfToxKi583Vs 48kKQrAZ4xJGnuj3Loobf35VNDL3kaAQ3h9sNQG8DlpoPsaIXfdPPhFbqW4g10jf P//rvlp+MqVtZ9u7qj4IGahmO1j/qY+JLaSJL8cXc/skuTbF7PsIgg9hraFx0Pww WSI7hRwoEW88uFCNp8/axRA4jNuRI95ICBlo9N9dsooBAtaezbFbQyS0RCfn3UCm UiWpcX4HfYtTrIsKrS5W7k2ZAh4DTZZ3sHCRBKhLaHZODdXyOSUnN4NlDkdyOfEI 4Q6OWdJfNMYqB/bEWgk/XLKWJp4naRRvMpBBhkPBpOvOD3Ub4oU8bcVEPflQh7YL fqYWsRBYfEtWSDBmcmNnhGMApiZ2tlx/hplw2BLgcHzxooOIsiMctHXHwI2QDo5u /iF5kWMM5ioGezIePbFhWzHY91aFCH3abYqD4jz8aUU4t7ROl+AGkpTlt9AXpvA7 LwctAdw7AdLPD7cQyx26 =3p1Q -----END PGP SIGNATURE----- --aFmjjgXCj8G16MPNlFbUbXVM7tLLA4QEd--