Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935139AbcKJQlc (ORCPT ); Thu, 10 Nov 2016 11:41:32 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:51796 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934921AbcKJQla (ORCPT ); Thu, 10 Nov 2016 11:41:30 -0500 Date: Thu, 10 Nov 2016 17:41:28 +0100 From: Peter Zijlstra To: Ingo Molnar Cc: Robert Richter , "Liang, Kan" , Andi Kleen , Jiri Olsa , Vince Weaver , lkml Subject: Re: [PATCH] perf/x86: Fix overlap counter scheduling bug Message-ID: <20161110164128.GZ3142@twins.programming.kicks-ass.net> References: <1478015068-14052-1-git-send-email-jolsa@kernel.org> <20161108122039.GP3142@twins.programming.kicks-ass.net> <20161108150949.GM26852@two.firstfloor.org> <37D7C6CF3E00A74B8858931C1DB2F07750C8D9D0@SHSMSX103.ccr.corp.intel.com> <20161108165749.GJ3117@twins.programming.kicks-ass.net> <37D7C6CF3E00A74B8858931C1DB2F07750C8DA4F@SHSMSX103.ccr.corp.intel.com> <20161108182739.GO3117@twins.programming.kicks-ass.net> <20161109142515.GY25086@rric.localdomain> <20161109155153.GQ3142@twins.programming.kicks-ass.net> <20161110080013.GA23431@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110080013.GA23431@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 7 On Thu, Nov 10, 2016 at 09:00:13AM +0100, Ingo Molnar wrote: > Would it be possible to also add debug code (or some other mechanism) to disallow > such buggy EVENT_CONSTRAINT_OVERLAP() definitions? Should certainly be possible if someone has the time for it I think. The rules are fairly straight forward, the only tricky bit is detectoring the actual overlap condition.