Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934700AbcKJRBa (ORCPT ); Thu, 10 Nov 2016 12:01:30 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34490 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934425AbcKJRB2 (ORCPT ); Thu, 10 Nov 2016 12:01:28 -0500 Date: Thu, 10 Nov 2016 12:01:23 -0500 (EST) Message-Id: <20161110.120123.1915127624714352140.davem@davemloft.net> To: rafalo@cadence.com Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5]] cadence: Add LSO support. From: David Miller In-Reply-To: <1478698862-12924-1-git-send-email-rafalo@cadence.com> References: <1478612463-15076-1-git-send-email-rafalo@cadence.com> <1478698862-12924-1-git-send-email-rafalo@cadence.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Nov 2016 08:01:54 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 16 From: Rafal Ozieblo Date: Wed, 9 Nov 2016 13:41:02 +0000 First, please remove the spurious closing bracket in your Subject line in future submittions. > + if (is_udp) /* is_udp is only set when (is_lso) is checked */ > + /* zero UDP checksum, not calculated by h/w for UFO */ > + udp_hdr(skb)->check = 0; This is really not ok. If UFO is in use it should not silently disable UDP checksums. If you cannot support UFO with proper checksumming, then you cannot enable support for that feature.