Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964778AbcKJRKb (ORCPT ); Thu, 10 Nov 2016 12:10:31 -0500 Received: from mail-it0-f50.google.com ([209.85.214.50]:37040 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935358AbcKJRK3 (ORCPT ); Thu, 10 Nov 2016 12:10:29 -0500 Subject: Re: [PATCH] block: cfq_cpd_alloc() should use @gfp To: Tejun Heo References: <20161110161637.GB26105@htj.duckdns.org> Cc: linux-block@vger.kernel.org, Dan Carpenter , linux-kernel@vger.kernel.org, kernel-team@fb.com From: Jens Axboe Message-ID: <58e4eab7-2d0e-d168-f1e5-3ed09c00e345@kernel.dk> Date: Thu, 10 Nov 2016 10:10:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110161637.GB26105@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 15 On 11/10/2016 09:16 AM, Tejun Heo wrote: > Re: [bug report] blkcg: replace blkcg_policy->cpd_size with > ->cpd_alloc/free_fn() methods > Reply-To: > In-Reply-To: <20161110133426.GA30610@mwanda> > > cfq_cpd_alloc() which is the cpd_alloc_fn implementation for cfq was > incorrectly hard coding GFP_KERNEL instead of using the mask specified > through the @gfp parameter. This currently doesn't cause any actual > issues because all current callers specify GFP_KERNEL. Fix it. Thanks Tejun, applied for 4.10. -- Jens Axboe