Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964933AbcKJR2M (ORCPT ); Thu, 10 Nov 2016 12:28:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41334 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935319AbcKJR2J (ORCPT ); Thu, 10 Nov 2016 12:28:09 -0500 Date: Thu, 10 Nov 2016 18:28:07 +0100 From: Corinna Vinschen To: Hisashi T Fujinaka Cc: Alexander Duyck , Netdev , "linux-kernel@vger.kernel.org" , Cao jin , intel-wired-lan , =?utf-8?B?SXp1bWksIFRha3Uv5rOJIOaLkw==?= Subject: Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Message-ID: <20161110172807.GH24351@calimero.vinschen.de> Mail-Followup-To: Hisashi T Fujinaka , Alexander Duyck , Netdev , "linux-kernel@vger.kernel.org" , Cao jin , intel-wired-lan , =?utf-8?B?SXp1bWksIFRha3Uv5rOJIOaLkw==?= References: <1478588780-24480-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20161108164214.GF31855@calimero.vinschen.de> <20161108183739.GA3744@calimero.vinschen.de> <20161110093549.GA24351@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="imjhCm/Pyz7Rq5F2" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 10 Nov 2016 17:28:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 53 --imjhCm/Pyz7Rq5F2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Nov 10 05:48, Hisashi T Fujinaka wrote: > On Thu, 10 Nov 2016, Corinna Vinschen wrote: > > On Nov 8 11:33, Alexander Duyck wrote: > ... > > > The question I would have is what is reading the device when it is in > > > this state. The watchdog and any other functions that would read the > > > device should be disabled. > > >=20 > > > One possibility could be a race between a call to igb_close and the > > > igb_suspend function. We have seen some of those pop up recently on > > > ixgbe and it looks like igb has the same bug. We should probably be > > > using the rtnl_lock to guarantee that netif_device_detach and the call > > > to __igb_close are completed before igb_close could possibly be called > > > by the network stack. > >=20 > > Do you have a pointer to the related ixgbe patch, by any chance? > ... > Here's the initial patch for igb I have, but it's on hold awaiting more > changes in ixgbe regarding AER. Thanks a lot! Corinna --imjhCm/Pyz7Rq5F2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYJK4nAAoJEPU2Bp2uRE+gmVAP/iftrKpyTIWgKNvhBMrmpuhl I3IzGMbATPo8KQYT0Y04onzsum8sTR3bdgCcoXVHdr5gtClIMoHDV2xEeGPxfarm bQ1t68h2p2syDik3DdeqGbaDNexMndN670bqG92PnrCISRoWra8w7hNcj9taMbQy 5egR2Tnz4xplM7X935lfi6/96Q36+k4zgTm0kRLNkXXd19fyYpuLHujglW67RDn9 6VRABGysi5/E59NI/J5sD7eBkVUaOltgHGGQlmRVrt/4MaPrMGIdaswHaDi653jK zWqSsdUpTLVFYyH02xshPykIC1FSAY7JYVnOzAqNAPIpBfxyTGzT1yzltisXX6kK 1TYu+jrQjWVNech8zEHhog+AaMxOe7Izv/YCXr2BcRTLpmZYZbVqAsigPtA2gumX KbtYxbdc/hCM72Og3Uxff/z7SVexXlDMolYPw8H9GCzVv3PNDvPosBMuWf7lx6ZY GgA8E1jKm1+18UVkjMd7RrH/0io+jVUi+1FABhfyS/NO3D6V3rGCnSqXS4tmmXn+ 4eRG5ZW5NizvyPUbw9zUXrHqH5HAQfvrJsLz1qszzm8FY86h3FzacrA0paNYhIPt Ev0IEVH/ow70Z6qQCipcCAhTFsOcHrY581EH8p9IfGiMH93Y9wjoLaJSNN71ZCWg cquZfauU0x1gdWER9CAD =1iD8 -----END PGP SIGNATURE----- --imjhCm/Pyz7Rq5F2--