Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820AbcKJSIG (ORCPT ); Thu, 10 Nov 2016 13:08:06 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:27112 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbcKJSIE (ORCPT ); Thu, 10 Nov 2016 13:08:04 -0500 Subject: Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing To: David Vrabel , Olaf Hering References: <1447186233-3194-1-git-send-email-boris.ostrovsky@oracle.com> <20161110162633.GA5301@aepfle.de> <0c993a89-83a1-d8a8-4927-d36660179256@oracle.com> <20161110164226.GA5937@aepfle.de> <085299df-0d6e-2e1b-02b8-34f33c3d4fa6@oracle.com> <20161110174734.GB5937@aepfle.de> <9c5d23e9-cb02-5f83-0422-2bbf55fb7779@citrix.com> Cc: konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, xen-devel@lists.xen.org From: Boris Ostrovsky Message-ID: <65c60eeb-3d04-ef86-b2c1-8d35276af236@oracle.com> Date: Thu, 10 Nov 2016 13:09:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9c5d23e9-cb02-5f83-0422-2bbf55fb7779@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 30 On 11/10/2016 12:49 PM, David Vrabel wrote: > On 10/11/16 17:47, Olaf Hering wrote: >> On Thu, Nov 10, Boris Ostrovsky wrote: >> >>> Are you sure it's this patch that causes the failure? >>> >>> I commented out '| VM_IO' and still unable to boot with this option. >> Yes, this works for me, sles12sp2 dom0+domU, which is linux-4.4 based: I've never tested on 4.4, this was added for 4.5 (with CC to stable#4.4) and now I am testing on 4.7) >> >> +++ b/drivers/xen/gntdev.c >> @@ -804,7 +804,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) >> >> vma->vm_ops = &gntdev_vmops; >> >> - vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP | VM_IO; >> + vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP /*| VM_IO*/; >> >> if (use_ptemod) >> vma->vm_flags |= VM_DONTCOPY; > I think we need a custom policy for this VMA with MPOL_F_MOF cleared. I think you are right, I remember when I was looking at this adding a policy was the other option. Let me look at this again. -boris