Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966039AbcKJUTl (ORCPT ); Thu, 10 Nov 2016 15:19:41 -0500 Received: from mail-qt0-f182.google.com ([209.85.216.182]:35262 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965259AbcKJUTk (ORCPT ); Thu, 10 Nov 2016 15:19:40 -0500 MIME-Version: 1.0 In-Reply-To: References: From: Dmitry Torokhov Date: Thu, 10 Nov 2016 12:19:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings To: Dmitry Torokhov Cc: Julia Lawall , kbuild-all@01.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman , Olof Johansson , Guenter Roeck , Thierry Escande , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 50 [ resending as plain text ] On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov wrote: > > > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall wrote: >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci >> >> CC: Dmitry Torokhov >> Signed-off-by: Julia Lawall >> Signed-off-by: Fengguang Wu >> --- >> >> 0-day warning related to the following commit: >> >> tree: >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git >> driver-core-testing >> head: dfea747d2aba77443acf7ce6fa37caa729bd034c >> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add >> test module for asynchronous probing >> >> I haven't checked the context in detail. >> >> >> test_async_driver_probe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/drivers/base/test/test_async_driver_probe.c >> +++ b/drivers/base/test/test_async_driver_probe.c >> @@ -119,7 +119,7 @@ static int __init test_async_probe_init( >> sync_dev_1 = platform_device_register_simple("test_sync_driver", >> 1, >> NULL, 0); >> if (IS_ERR(async_dev_1)) { >> - error = PTR_ERR(sync_dev_1); >> + error = PTR_ERR(async_dev_1); > > > NAK. It should be "if (IS_ERR(sync_dev_1)) {" > >> >> pr_err("failed to create sync_dev_1: %d", error); >> goto err_unregister_sync_driver; >> } > >