Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965842AbcKJUWe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 15:22:34 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:20769 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S965291AbcKJUWc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 15:22:32 -0500
X-IronPort-AV: E=Sophos;i="5.31,619,1473112800"; 
   d="scan'208";a="244544283"
Date: Thu, 10 Nov 2016 21:22:30 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Dmitry Torokhov <dtor@chromium.org>
cc: kbuild-all@01.org, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Olof Johansson <olofj@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Thierry Escande <thierry.escande@collabora.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings
In-Reply-To: <CAE_wzQ9o6U2bM2=t-oAguyGFhCGwj=s9LwtFvwcWjRyOEAFQBw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1611102121180.1970@hadrien>
References: <alpine.DEB.2.20.1611102113460.1970@hadrien> <CAE_wzQ_st6sBugdFRGX8VgSXcRqNCo3QcPwr5B8XpR-cQft6Eg@mail.gmail.com> <CAE_wzQ9o6U2bM2=t-oAguyGFhCGwj=s9LwtFvwcWjRyOEAFQBw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1856
Lines: 61



On Thu, 10 Nov 2016, Dmitry Torokhov wrote:

> [ resending as plain text ]
>
> On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov <dtor@chromium.org> wrote:
> >
> >
> > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >>
> >> PTR_ERR should access the value just tested by IS_ERR
> >>
> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> >>
> >> CC: Dmitry Torokhov <dtor@chromium.org>
> >> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> >> ---
> >>
> >> 0-day warning related to the following commit:
> >>
> >> tree:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> >> driver-core-testing
> >> head:   dfea747d2aba77443acf7ce6fa37caa729bd034c
> >> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add
> >> test module for asynchronous probing
> >>
> >> I haven't checked the context in detail.
> >>
> >>
> >>  test_async_driver_probe.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- a/drivers/base/test/test_async_driver_probe.c
> >> +++ b/drivers/base/test/test_async_driver_probe.c
> >> @@ -119,7 +119,7 @@ static int __init test_async_probe_init(
> >>         sync_dev_1 = platform_device_register_simple("test_sync_driver",
> >> 1,
> >>                                                      NULL, 0);
> >>         if (IS_ERR(async_dev_1)) {
> >> -               error = PTR_ERR(sync_dev_1);
> >> +               error = PTR_ERR(async_dev_1);
> >
> >
> > NAK. It should be "if (IS_ERR(sync_dev_1)) {"

Indeed, I should have noticed that.  Will you make the fix, or should I
revise the proposed patch?

julia

> >
> >>
> >>                 pr_err("failed to create sync_dev_1: %d", error);
> >>                 goto err_unregister_sync_driver;
> >>         }
> >
> >
>