Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966277AbcKJUtR (ORCPT ); Thu, 10 Nov 2016 15:49:17 -0500 Received: from muru.com ([72.249.23.125]:58860 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966239AbcKJUtP (ORCPT ); Thu, 10 Nov 2016 15:49:15 -0500 Date: Thu, 10 Nov 2016 13:49:11 -0700 From: Tony Lindgren To: Brian Norris Cc: Dmitry Torokhov , "Rafael J . Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , lkml , Brian Norris , "linux-pm@vger.kernel.org" Subject: Re: [PATCH] PM / wakeirq: report wakeup events in dedicated wake-IRQs Message-ID: <20161110204911.GK27724@atomide.com> References: <1478801227-65527-1-git-send-email-briannorris@chromium.org> <20161110184910.GA135921@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110184910.GA135921@google.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 21 * Brian Norris [161110 11:49]: > On Thu, Nov 10, 2016 at 10:13:55AM -0800, Dmitry Torokhov wrote: > > On Thu, Nov 10, 2016 at 10:07 AM, Brian Norris wrote: > > > It's important that user space can figure out what device woke the > > > system from suspend -- e.g., for debugging, or for implementing > > > conditional wake behavior. Dedicated wakeup IRQs don't currently do > > > that. > > > > > > Let's report the event (pm_wakeup_event()) and also allow drivers to > > > synchronize with these events in their resume path (hence, disable_irq() > > > instead of disable_irq_nosync()). > > > > Hmm, dev_pm_disable_wake_irq() is called from > > rpm_suspend()/rpm_resume() that take dev->power.lock spinlock and > > disable interrupts. Dropping _nosync() feels dangerous. > > Indeed. So how do you suggest we get sane wakeup reports? __pm_wakeup_event() ? Tony