Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965267AbcKJVao (ORCPT ); Thu, 10 Nov 2016 16:30:44 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:32973 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964811AbcKJVam (ORCPT ); Thu, 10 Nov 2016 16:30:42 -0500 Date: Thu, 10 Nov 2016 13:30:39 -0800 From: Brian Norris To: Tony Lindgren Cc: Dmitry Torokhov , "Rafael J . Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , lkml , Brian Norris , "linux-pm@vger.kernel.org" Subject: Re: [PATCH] PM / wakeirq: report wakeup events in dedicated wake-IRQs Message-ID: <20161110213038.GA108490@google.com> References: <1478801227-65527-1-git-send-email-briannorris@chromium.org> <20161110184910.GA135921@google.com> <20161110204911.GK27724@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110204911.GK27724@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 32 On Thu, Nov 10, 2016 at 01:49:11PM -0700, Tony Lindgren wrote: > * Brian Norris [161110 11:49]: > > On Thu, Nov 10, 2016 at 10:13:55AM -0800, Dmitry Torokhov wrote: > > > On Thu, Nov 10, 2016 at 10:07 AM, Brian Norris wrote: > > > > It's important that user space can figure out what device woke the > > > > system from suspend -- e.g., for debugging, or for implementing > > > > conditional wake behavior. Dedicated wakeup IRQs don't currently do > > > > that. > > > > > > > > Let's report the event (pm_wakeup_event()) and also allow drivers to > > > > synchronize with these events in their resume path (hence, disable_irq() > > > > instead of disable_irq_nosync()). > > > > > > Hmm, dev_pm_disable_wake_irq() is called from > > > rpm_suspend()/rpm_resume() that take dev->power.lock spinlock and > > > disable interrupts. Dropping _nosync() feels dangerous. > > > > Indeed. So how do you suggest we get sane wakeup reports? > > __pm_wakeup_event() ? That's not the difficult part. (This patch already uses pm_wakeup_event() correctly. It's in the ISR, and it doesn't get nested within any other lock-holding code, so it should use the non-underscore version, which grabs the lock.) The difficult part is guaranteeing that the wake IRQ gets reported at the appropriate time. It seems highly unlikely that a threaded IRQ like this would take longer than the time for devices to resume, but it's not guaranteed. So the question is where/when/how we call synchronize_irq(). Brian