Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936479AbcKJWj2 (ORCPT ); Thu, 10 Nov 2016 17:39:28 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33870 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936198AbcKJWjY (ORCPT ); Thu, 10 Nov 2016 17:39:24 -0500 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: <20161107134215.2v5leafss2mamim5@home.ouaza.com> References: <1477380887-21333-1-git-send-email-mszeredi@redhat.com> <1477380887-21333-4-git-send-email-mszeredi@redhat.com> <20161025115748.ydhkkp5cfcdnjzwn@home.ouaza.com> <20161107110319.7goz3ym3e6fu5lag@home.ouaza.com> <20161107134215.2v5leafss2mamim5@home.ouaza.com> From: Miklos Szeredi Date: Thu, 10 Nov 2016 23:39:17 +0100 Message-ID: Subject: Re: [PATCH 3/3] ovl: redirect on rename-dir To: Raphael Hertzog Cc: Konstantin Khlebnikov , Miklos Szeredi , "linux-unionfs@vger.kernel.org" , Guillem Jover , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 22 New version is at: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #redirect News: - it actually should work in all cases - when rename is not cross directory, just store the new name instead of a full path, as suggested by Amir - when redirect path is too long fall back to EXDEV (the max length should probably be a module param) About turning the feature on or off. Yes, maybe the empty checking is too complicated. Going one simpler: - default to old behavior, turn on with mount option - add module option and kernel compile option to turn on the feature by default I guess distros wil simply enable this by default, since back compatibility is basically a non-issue. Thanks, Miklos