From: "Alex Ng (LIS)" <alexng@microsoft.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
        KY Srinivasan <kys@microsoft.com>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>,
        Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show
 max page count
Thread-Topic: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show
 max page count
Thread-Index: AQHSNGvQ2wwgEybzlU+wdrN2cgP+s6DSow+AgAAFBtA=
Date: Thu, 10 Nov 2016 19:38:41 +0000
Message-ID: <MWHPR03MB273436661E188028EF588B1AD8B80@MWHPR03MB2734.namprd03.prod.outlook.com>
References: <1478030807-5915-1-git-send-email-kys@exchange.microsoft.com>
 <1478030854-5970-1-git-send-email-kys@exchange.microsoft.com>
 <1478030854-5970-8-git-send-email-kys@exchange.microsoft.com>
 <20161110190924.GD28701@mwanda>
In-Reply-To: <20161110190924.GD28701@mwanda>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2016 19:38:41.1968
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2496
X-OriginatorOrg: microsoft.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAANHkgn027061
Content-Length: 2085
Lines: 55

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, November 10, 2016 11:09 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; Stephen Hemminger
> <sthemmin@microsoft.com>; Alex Ng (LIS) <alexng@microsoft.com>; Alex
> Ng (LIS) <alexng@microsoft.com>
> Subject: Re: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show
> max page count
> 
> On Tue, Nov 01, 2016 at 01:07:28PM -0700, kys@exchange.microsoft.com
> wrote:
> > From: Alex Ng <alexng@messages.microsoft.com>
> >
> > Balloon driver was only printing the size of the info blob and not the
> > actual content. This fixes it so that the info blob (max page count as
> > configured in Hyper-V) is printed out.
> >
> > Signed-off-by: Alex Ng <alexng@microsoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/hv_balloon.c |    9 +++++++--
> >  1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> > index 8cac29a..14c3dc4 100644
> > --- a/drivers/hv/hv_balloon.c
> > +++ b/drivers/hv/hv_balloon.c
> > @@ -1034,8 +1034,13 @@ static void process_info(struct
> hv_dynmem_device *dm, struct dm_info_msg *msg)
> >
> >  	switch (info_hdr->type) {
> >  	case INFO_TYPE_MAX_PAGE_CNT:
> > -		pr_info("Received INFO_TYPE_MAX_PAGE_CNT\n");
> > -		pr_info("Data Size is %d\n", info_hdr->data_size);
> > +		if (info_hdr->data_size == sizeof(__u64)) {
> > +			__u64 *max_page_count = (__u64 *)&info_hdr[1];
> 
> Why __u64 instead of u64?  Is this code shared with user space?

__u64 was being used in other parts of this code already and I decided to follow that.

I wasn't aware of this distinction between the two.
This code is not shared in user-space, so perhaps we should clean up this file in a future patch.

Thanks for bringing it up.

> 
> regards,
> dan carpenter
>