Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965038AbcKJXxw (ORCPT ); Thu, 10 Nov 2016 18:53:52 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:36387 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932739AbcKJXxu (ORCPT ); Thu, 10 Nov 2016 18:53:50 -0500 MIME-Version: 1.0 In-Reply-To: <1478775952.2536.27.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> <1478089382.2710.20.camel@synopsys.com> <1478775952.2536.27.camel@synopsys.com> From: Dave Airlie Date: Fri, 11 Nov 2016 09:53:49 +1000 Message-ID: Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge To: Alexey Brodkin Cc: "airlied@redhat.com" , "daniel.vetter@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "architt@codeaurora.org" , "Ramiro.Oliveira@synopsys.com" , "Eugeniy.Paltsev@synopsys.com" , "airlied@linux.ie" , "linux-snps-arc@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAANrvNP027187 Content-Length: 2781 Lines: 72 On 10 November 2016 at 21:06, Alexey Brodkin wrote: > Hi Daniel, David, > > On Wed, 2016-11-02 at 12:23 +0000, Alexey Brodkin wrote: >> Hi Daniel, David, >> >> On Mon, 2016-10-24 at 18:33 +0000, Alexey Brodkin wrote: >> > >> > Hi Daniel, >> > >> > > >> > > >> > > -----Original Message----- >> > > From: linux-snps-arc [mailto:linux-snps-arc-bounces@lists.infradead.org] On Behalf Of Alexey Brodkin >> > > Sent: 19 октября 2016 г. 12:33 >> > > To: dri-devel@lists.freedesktop.org; architt@codeaurora.org; Eugeniy.Paltsev@synopsys.com >> > > Cc: linux-snps-arc@lists.infradead.org; linux-kernel@vger.kernel.org >> > > Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge >> > > >> > > Hi Archit, all, >> > > >> > > On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote: >> > > > >> > > > >> > > > >> > > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: >> > > > > >> > > > > >> > > > > >> > > > > ARC PGU driver starts crashing on initialization after >> > > > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' >> > > > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer >> > > > > of "drm_i2c_encoder_driver" structure, which doesn't exist after >> > > > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. >> > > > > So, when we call "encoder_init" function from this structure driver >> > > > > crashes. >> > > >> > > [snip] >> > > >> > > > >> > > > >> > > > Looks good now. >> > > > >> > > > Reviewed-by: Archit Taneja >> > > >> > > And IMHO it would be really good to get this one back-ported to 4.8 >> > > because it really fixes kernel crash if ARC PGU driver is used. >> > > >> > > It might be a bit of a problem because patch itself a little-bit larger >> > > than formal requirement for stable backports but let's see if it gets accepted. >> > >> > Could you please pick this one up? >> > I may alternatively send a pull-request to David but not sure if 1 patch worth it. >> > >> > Also if that's not really too late it would be good to get this one in 4.9 since the patch >> > In question fixes a real driver crash on its instantiation. >> > Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount >> > of changes I think there's barely a chance for it it to be accepted in stable branches... >> > which in its turn makes at least 4.9 very desirable. >> >> Any chance this one gets accepted anytime soon? > > Please treat this as another polite reminder to apply this patch. > If you prefer I may send a pull-request otherwise. Please send a pull request for -fixes. For everyone else, pull requests for single patches is not overkill, it fits into my workflow a lot better. Dave.