From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
        "bp@alien8.de" <bp@alien8.de>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dvyukov@google.com" <dvyukov@google.com>,
        "corbet@lwn.net" <corbet@lwn.net>, "arnd@arndb.de" <arnd@arndb.de>,
        "matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "aryabinin@virtuozzo.com" <aryabinin@virtuozzo.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "riel@redhat.com" <riel@redhat.com>,
        "lwoodman@redhat.com" <lwoodman@redhat.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "hpa@zytor.com" <hpa@zytor.com>, "luto@kernel.org" <luto@kernel.org>,
        "glider@google.com" <glider@google.com>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>
Subject: Re: [RFC PATCH v3 02/20] x86: Set the write-protect cache mode for
 full PAT support
Thread-Topic: [RFC PATCH v3 02/20] x86: Set the write-protect cache mode for
 full PAT support
Thread-Index: AQHSOu1fwLqIaWOzCkmLAhzIu3DgZKDSMr4AgADMJgA=
Date: Fri, 11 Nov 2016 01:26:48 +0000
Message-ID: <1478827480.20881.142.camel@hpe.com>
References: <20161110003426.3280.2999.stgit@tlendack-t1.amdoffice.net>
         <20161110003448.3280.27573.stgit@tlendack-t1.amdoffice.net>
         <20161110131400.bmeoojsrin2zi2w2@pd.tnic>
In-Reply-To: <20161110131400.bmeoojsrin2zi2w2@pd.tnic>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <5A008A45AA7B1344A2346C26C53E4AD3@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2016 01:26:48.5842
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0006
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAB1QwSo027534
Content-Length: 1019
Lines: 25

On Thu, 2016-11-10 at 14:14 +0100, Borislav Petkov wrote:
> + Toshi.
> 
> On Wed, Nov 09, 2016 at 06:34:48PM -0600, Tom Lendacky wrote:
> > 
> > For processors that support PAT, set the write-protect cache mode
> > (_PAGE_CACHE_MODE_WP) entry to the actual write-protect value
> > (x05).

Using slot 6 may be more cautious (for the same reason slot 7 was used
for WT), but I do not have a strong opinion for it.

set_page_memtype() cannot track the use of WP type since there is no
extra-bit available for WP, but WP is only supported by
early_memremap_xx() interfaces in this series.  So, I think we should
just document that WP is only intended for temporary mappings at boot-
time until this issue is resolved.  Also, we need to make sure that
this early_memremap for WP is only called after pat_init() is done.

A nit - please add WP to the function header comment below.
"This function initializes PAT MSR and PAT table with an OS-defined
value to enable additional cache attributes, WC and WT."

Thanks,
-Toshi